Adjust "ast" imports to make pytype happy. #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that pytype is a bit more finicky about imports, and differentiates between '*' imports for export, and imports for use in the local pyi. This adjusts ast.pyi to make pytype understand it again.
|
Also, are the mypy_selftest tests just broken right now? |
|
Let me look into the test failures. I may have merged some old code that
got broken by more recent developments.
|
|
No, I think it's just python/mypy#3543 -- I can't reproduce it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that pytype is a bit more finicky about imports, and differentiates between
*imports for export, and imports for use in the local pyi. This adjustsast.pyito make pytype understand it again, after #1515