Add forgotten self for thirdparty #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Oct 30, 2016
| @@ -226,12 +226,12 @@ def get_provider(package_or_requirement: str) -> IResourceProvider: ... | |||
| def get_provider(package_or_requirement: Requirement) -> Distribution: ... | |||
|
|
|||
| class IMetadataProvider: | |||
There was a problem hiding this comment.
This class is weird. Its source code really doesn't have 'self' parameters. I suppose this is implicitly using zope.Interfaces (but not explicitly -- in fact it seems it's just documentation at this point). I wonder if we should just remove these 'I' classes from this package in typeshed -- if anything explicitly references them, it probably won't work.
Maybe we should ask the pypa folks, and leave this file alone for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #638.