Skip to content

Add forgotten self for thirdparty #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2016
Merged

Add forgotten self for thirdparty #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion third_party/2/pymssql.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Cursor(object):
def __init__(self) -> None: ...
def __iter__(self): ...
def __next__(self) -> Any: ...
def callproc(procname: str, **kwargs) -> None: ...
def callproc(self, procname: str, **kwargs) -> None: ...
def close(self) -> None: ...
def execute(self, stmt: str,
params: Optional[Union[Scalar, Tuple[Scalar, ...],
Expand Down
12 changes: 6 additions & 6 deletions third_party/3/pkg_resources.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,12 @@ def get_provider(package_or_requirement: str) -> IResourceProvider: ...
def get_provider(package_or_requirement: Requirement) -> Distribution: ...

class IMetadataProvider:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is weird. Its source code really doesn't have 'self' parameters. I suppose this is implicitly using zope.Interfaces (but not explicitly -- in fact it seems it's just documentation at this point). I wonder if we should just remove these 'I' classes from this package in typeshed -- if anything explicitly references them, it probably won't work.

Maybe we should ask the pypa folks, and leave this file alone for now.

def has_metadata(name: str) -> bool: ...
def metadata_isdir(name: str) -> bool: ...
def metadata_listdir(name: str) -> List[str]: ...
def get_metadata(name: str) -> str: ...
def get_metadata_lines(name: str) -> Generator[List[str], None, None]: ...
def run_script(script_name: str, namespace: Dict[str, Any]) -> None: ...
def has_metadata(self, name: str) -> bool: ...
def metadata_isdir(self, name: str) -> bool: ...
def metadata_listdir(self, name: str) -> List[str]: ...
def get_metadata(self, name: str) -> str: ...
def get_metadata_lines(self, name: str) -> Generator[List[str], None, None]: ...
def run_script(self, script_name: str, namespace: Dict[str, Any]) -> None: ...


class ResolutionError(Exception): ...
Expand Down