-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
rm -rf stubs/filelock #8046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm -rf stubs/filelock #8046
Conversation
See python#8043 Please confirm that a new types-filelock has been released before merging
Diff from mypy_primer, showing the effect of this PR on open source code: mypy (https://github.com/python/mypy)
+ mypy/test/testpep561.py:2: error: Library stubs not installed for "filelock" (or incompatible with Python 3.6) [import]
+ mypy/test/testpep561.py:2: note: Hint: "python3 -m pip install types-filelock"
+ mypy/test/testpep561.py:2: note: (or run "mypy --install-types" to install all missing stub packages)
+ mypy/test/testpep561.py:2: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
Depends on |
There isn't actually any dependency. mypy_primer just needs to be updated to install filelock when setting up mypy (but it also doesn't really matter if we don't update mypy_primer, since it'll happily diff things out). The mypy PR is just a nit, since self check would fail if someone installed filelock 3.2 |
Ahh sorry I misunderstood, and didn't want to inadvertently break mypy! Thanks, great, let's merge then. |
Updated primer in hauntsaninja/mypy_primer@d91de1f |
Well we do need to wait for a new types-filelock :-) |
"let's merge in a little bit" |
See #8043
Please confirm that a new types-filelock has been released before
merging