Skip to content

Add stable diffusion training script for PyTorch/XLA #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

bhavya01
Copy link
Collaborator

@bhavya01 bhavya01 commented Sep 3, 2024

No description provided.

@bhavya01 bhavya01 requested a review from JackCaoG September 3, 2024 21:36
@bhavya01 bhavya01 self-assigned this Sep 3, 2024
@JackCaoG
Copy link

JackCaoG commented Sep 3, 2024

can you also add a README?

@bhavya01
Copy link
Collaborator Author

bhavya01 commented Sep 4, 2024

can you also add a README?

Done

@bhavya01 bhavya01 requested a review from entrpn September 4, 2024 18:17
Comment on lines +607 to +608
from torch_xla.distributed.fsdp.utils import apply_xla_patch_to_nn_linear
unet = apply_xla_patch_to_nn_linear(unet, xs.xla_patched_nn_linear_forward)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do it manually? I thought it is automatically somehow

Copy link

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

@bhavya01 bhavya01 requested a review from entrpn September 5, 2024 18:24
@bhavya01 bhavya01 merged commit 74f74ea into main Sep 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants