Build libtorch with new gcc ABI #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
August 6, 2019 18:50
yf225
changed the title
ezyang
reviewed
Aug 8, 2019
| if [[ -z "$1" || "$1" == 0 || "$1" == "OFF" ]]; then | ||
| echo 1 | ||
|
|
||
| # NOTE [ Building libtorch with old vs. new gcc ABI ] |
There was a problem hiding this comment.
Any substantive changes here?
There was a problem hiding this comment.
There is no substantive change here. The only main change is that we are only checking for cxx11 / pre-cxx11 symbols in our own namespaces (i.e. c10 / at / caffe2 / torch), since checking for those symbols in all namespaces doesn't give us reliable results:
# NOTE: Checking the above symbols in all namespaces doesn't work, because
# devtoolset7 always produces some cxx11 symbols even if we build with old ABI,
# and CuDNN always has pre-cxx11 symbols even if we build with new ABI using gcc 5.4.
# Instead, we *only* check the above symbols in the following namespaces:
added 3 commits
August 12, 2019 11:29
yf225
changed the title
soumith
approved these changes
Aug 14, 2019
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 19, 2019
Summary: This PR enables building libtorch with new ABI, using gcc 5.4 on Ubuntu 16.04. Accompanying PR: pytorch/builder#335. Pull Request resolved: #23908 Differential Revision: D16898009 Pulled By: yf225 fbshipit-source-id: 516b444c1fc94c7b05d3be84ef81ef23e9041bfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytorch/pytorch#23908