Build libtorch binary with new ABI #23908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
force-pushed
the
cpp_new_abi
branch
2 times, most recently
from
33bb9cf to
ff73307
Compare
added 3 commits
August 6, 2019 19:02
added 2 commits
August 6, 2019 20:20
yf225
force-pushed
the
cpp_new_abi
branch
2 times, most recently
from
d51156f to
1ab89ea
Compare
yf225
force-pushed
the
cpp_new_abi
branch
2 times, most recently
from
ac849a4 to
bc44c4e
Compare
added 2 commits
August 7, 2019 10:11
added 3 commits
August 10, 2019 15:45
yf225
force-pushed
the
cpp_new_abi
branch
2 times, most recently
from
71d255c to
4eb33e5
Compare
This reverts commit 464de5f.
yf225
force-pushed
the
cpp_new_abi
branch
2 times, most recently
from
ec7c564 to
de72d47
Compare
yf225
changed the title
ezyang
reviewed
Aug 17, 2019
| return filtered_packaging_variants | ||
| else: | ||
| return packaging_variants | ||
| return [PackageFormatConfigNode(self, k, v) for k, v in self.py_tree.items()] |
There was a problem hiding this comment.
Nice. I really hated the special casing here lol
ezyang
approved these changes
Aug 17, 2019
|
@kostmo you should review the generator bits please |
kostmo
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building libtorch with new ABI, using gcc 5.4 on Ubuntu 16.04.
Accompanying PR: pytorch/builder#335.