Skip to content

Extend PyBundledModule with extension.BundledModule #10447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhenyan-zhang-meta opened this issue Apr 24, 2025 · 0 comments
Open

Extend PyBundledModule with extension.BundledModule #10447

zhenyan-zhang-meta opened this issue Apr 24, 2025 · 0 comments
Assignees
Labels
module: extension Issues related to code under extension/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@zhenyan-zhang-meta
Copy link
Contributor

Context

This issue is a step of #9638 and a sequel of #10375.

In #9638, we want to have extension.Module as the single source of implementation in pybindings, which means that pybindings.PyModule should use extension.Module rather than its own pybindings.Module.

Proposal

Now that we have extension.BundledModule ready, we want to test it out by having our existing PyBundledModule to extend it, and let verify_result_with_bundled_expected_output to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

@zhenyan-zhang-meta zhenyan-zhang-meta added module: extension Issues related to code under extension/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 24, 2025
@zhenyan-zhang-meta zhenyan-zhang-meta self-assigned this Apr 24, 2025
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…Module`

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…Module`

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

ghstack-source-id: 279969993
Pull Request resolved: #10450
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
ghstack-source-id: 280147380
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 280175151

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta pushed a commit that referenced this issue Apr 24, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 280178134

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 280825734

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281069664

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 29, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281084621

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281088483

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281091723

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281093938

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281098114

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281114545

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281124470

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…le` with `extension.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…ion.BundledModule`"

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)

[ghstack-poisoned]
zhenyan-zhang-meta added a commit that referenced this issue Apr 30, 2025
…Module`

Pull Request resolved: #10450

#10447

# Context

This issue is a step of #9638.

In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`.

# Proposal

Now that we have `extension.BundledModule` ready, we want to test it out by having our existing `PyBundledModule` to extend it, and let `verify_result_with_bundled_expected_output` to use it, so that we can test out the whole thing with https://github.com/pytorch/executorch/blob/fb45e19055a92d2a91a4d4b7008e135232cbb14b/devtools/bundled_program/test/test_end2end.py
ghstack-source-id: 281229771

Differential Revision: [D73564127](https://our.internmc.facebook.com/intern/diff/D73564127/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: extension Issues related to code under extension/ triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

1 participant