-
Notifications
You must be signed in to change notification settings - Fork 607
Arm build and runner CI #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Arm build and runner CI #1111
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b98ba52
add a docker config
kirklandsign 1c2da64
add a workflow to trigger it
kirklandsign f575b59
comment out
kirklandsign fb5e1da
need to add to workflow
kirklandsign 6e5c1eb
fix lintrunner
kirklandsign 1f0bc6c
dockerfile
kirklandsign 0259e64
sh
kirklandsign 37e574e
set up sdk
kirklandsign c78399c
temp run
kirklandsign 5572a94
trigger pull
kirklandsign f663e7b
build tool
kirklandsign a5b8db4
fix sdk path
kirklandsign 3b9da88
fix buck2
kirklandsign 9657c5a
fix path
kirklandsign 10038e9
fix path
kirklandsign 6a6478d
fix path
kirklandsign 77cc058
path
kirklandsign 404481a
fix
kirklandsign 678ac63
sh path
kirklandsign 010f4c7
mkdir -p
kirklandsign 5295146
chown fix
kirklandsign 7ef54d5
chown fix
kirklandsign 181fa12
run as user
kirklandsign 5fc0f15
Revert "run as user"
kirklandsign 1d2e724
copy stuff
kirklandsign 5e43b99
copy stuff
kirklandsign c1e4233
print dir
kirklandsign ab6e335
refresh
kirklandsign 1388e36
setup git
kirklandsign 170eb22
remove arm
kirklandsign e4c9e77
CI caught an issue
kirklandsign 65e0424
clean up
kirklandsign e1aab58
update docker image name
kirklandsign cf47270
update path
kirklandsign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,5 +51,10 @@ COPY ./requirements-lintrunner.txt requirements-lintrunner.txt | |
RUN if [ -n "${LINTRUNNER}" ]; then bash ./install_linter.sh; fi | ||
RUN rm install_linter.sh utils.sh requirements-lintrunner.txt | ||
|
||
ARG ARM_SDK | ||
COPY --chown=ci-user:ci-user ./arm /opt/arm | ||
# Set up ARM SDK if needed | ||
RUN if [ -n "${ARM_SDK}" ]; then git config --global user.email "[email protected]"; git config --global user.name "OSS CI"; bash /opt/arm/setup.sh --i-agree-to-the-contained-eula /opt/arm-sdk; chown -R ci-user:ci-user /opt/arm-sdk; fi | ||
|
||
USER ci-user | ||
CMD ["bash"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW how do we trigger an image build if examples/arm changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only should need
setup.sh
and patches FWIW. But your question is valid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's harder to copy the specific files than the entire dir :p