Arm build and runner CI #1111

kirklandsign · 2023-10-30T23:11:16Z

Add the setup part to docker image to make the run faster.

pytorch-bot · 2023-10-30T23:11:18Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1111

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Unrelated Failures

As of commit cf47270 with merge base 251801e ():

NEW FAILURES - The following jobs have failed:

trunk / test-models-macos (cmake, resnet50, portable, macos-m1-12) / macos-job (gh)
trunk / test-models-macos (cmake, softmax, portable, macos-m1-12) / macos-job (gh)
trunk / test-models-macos (cmake, softmax, xnnpack, macos-m1-12) / macos-job (gh)
trunk / test-models-macos (cmake, vit, portable, macos-m1-12) / macos-job (gh)
trunk / test-models-macos (cmake, w2l, portable, macos-m1-12) / macos-job (gh)
trunk / test-models-macos (cmake, w2l, xnnpack-delegation, macos-m1-12) / macos-job (gh)

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn · 2023-10-31T18:05:13Z

.github/workflows/pull.yml

+    uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
+    with:
+      runner: linux.2xlarge
+      docker-image: executorch-ubuntu-22.04-clang12


You would need to use the new ARM image here once it's ready

Yes! Please let me know when it's ready. So far I use the main image just for debugging

@huydhn ETA when it will be ready? @digantdesai if Arm really want to enable it asap, we can enable it by installing the their simulator and toolchains on the fly like this.

huydhn · 2023-10-31T18:05:28Z

.github/workflows/trunk.yml

+    uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
+    with:
+      runner: linux.2xlarge
+      docker-image: executorch-ubuntu-22.04-clang12


Same comment about using the new ARM image

This reverts commit 181fa12.

guangy10 · 2023-10-31T21:29:39Z

.github/workflows/pull.yml

@@ -110,3 +110,21 @@ jobs:
    uses: ./.github/workflows/_unittest.yml
    with:
      docker-image: executorch-ubuntu-22.04-clang12
+
+  test-arm-backend-delegation:


Are we running this on PRs? I think we should run all vendor-specific jobs ins trunk but with the ability to run it on PRs with labeling.

Yes. I will remove this part. It's testing only.

guangy10

Thanks Hansong and Huy for helping on this

kirklandsign · 2023-10-31T21:33:37Z

.ci/docker/build.sh

@@ -21,11 +21,15 @@ BUCK2_VERSION=$(cat ci_commit_pins/buck2.txt)

 case "${IMAGE_NAME}" in
  executorch-ubuntu-22.04-clang12)
+    ARM_SDK=yes


Will remove this line in the end

kirklandsign · 2023-10-31T21:50:19Z

.ci/docker/build.sh

@@ -41,6 +45,9 @@ BUILD_DOCS=1
 # Copy requirements-lintrunner.txt from root to here
 cp ../../requirements-lintrunner.txt ./

+# Copy arm setup script from root to here
+cp -r ../../examples/arm/ ./arm


BTW how do we trigger an image build if examples/arm changes?

we only should need setup.sh and patches FWIW. But your question is valid.

It's harder to copy the specific files than the entire dir :p

huydhn · 2023-10-31T23:25:00Z

.github/workflows/trunk.yml

+    uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
+    with:
+      runner: linux.2xlarge
+      docker-image: executorch-ubuntu-22.04-clang12-arm-sdk


The name here should be executorch-ubuntu-22.04-arm-sdk I think. Once you set the correct name, the failed jobs here https://github.com/pytorch/executorch/actions/runs/6712861373/job/18243312911 should use the correct Docker image

facebook-github-bot · 2023-11-01T00:00:13Z

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-11-01T00:53:18Z

@kirklandsign merged this pull request in 2535a25.

add a docker config

b98ba52

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 30, 2023

add a workflow to trigger it

1c2da64

kirklandsign added the ciflow/trunk label Oct 30, 2023

kirklandsign added 18 commits October 30, 2023 20:37

comment out

f575b59

need to add to workflow

fb5e1da

fix lintrunner

6e5c1eb

dockerfile

1f0bc6c

sh

0259e64

set up sdk

37e574e

temp run

c78399c

trigger pull

5572a94

build tool

f663e7b

fix sdk path

a5b8db4

fix buck2

3b9da88

fix path

9657c5a

fix path

10038e9

fix path

6a6478d

path

77cc058

fix

404481a

sh path

678ac63

mkdir -p

010f4c7

huydhn reviewed Oct 31, 2023

View reviewed changes

kirklandsign added 5 commits October 31, 2023 11:08

chown fix

5295146

chown fix

7ef54d5

run as user

181fa12

Revert "run as user"

5fc0f15

This reverts commit 181fa12.

copy stuff

1d2e724

kirklandsign added 5 commits October 31, 2023 12:41

copy stuff

5e43b99

print dir

c1e4233

refresh

ab6e335

setup git

1388e36

remove arm

170eb22

guangy10 reviewed Oct 31, 2023

View reviewed changes

CI caught an issue

e4c9e77

guangy10 reviewed Oct 31, 2023

View reviewed changes

kirklandsign commented Oct 31, 2023

View reviewed changes

clean up

65e0424

kirklandsign changed the title ~~add a docker config~~ Arm build and runner CI Oct 31, 2023

huydhn reviewed Oct 31, 2023

View reviewed changes

update docker image name

e1aab58

huydhn approved these changes Oct 31, 2023

View reviewed changes

update path

cf47270

facebook-github-bot closed this in 2535a25 Nov 1, 2023

facebook-github-bot added the Merged label Nov 1, 2023

This was referenced Nov 1, 2023

[TOSA] Enable running arm_tosa_e2e tests on public CI #1100

Closed

[TOSA] Enable Running arm_e2e_tests with Python Unit Test #1105

Closed

robert-kalmar mentioned this pull request Jun 10, 2025

NXP backend: Add docker image for nxp backend tests #11473

Draft

Arm build and runner CI #1111

Arm build and runner CI #1111

Uh oh!

Conversation

kirklandsign commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1111

❌ 6 New Failures, 2 Unrelated Failures

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guangy10 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 1, 2023

Uh oh!

facebook-github-bot commented Nov 1, 2023

Uh oh!

Uh oh!

kirklandsign commented Oct 30, 2023 •

edited

Loading

pytorch-bot bot commented Oct 30, 2023 •

edited

Loading