Skip to content

Add int32 quant/dequant back #14269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add int32 quant/dequant back #14269

wants to merge 4 commits into from
+1,366 −629

Conversation

mcremon-meta
Copy link
Contributor

Summary: Now that the previous diff exists, we can add the int32 case back without adding to the code size of deployed models.

Differential Revision: D82282481

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14269

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Cancelled Jobs

As of commit f5cb955 with merge base eec95d0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@facebook-github-bot
Copy link
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82282481.

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82282481.

mcremon-meta added a commit that referenced this pull request Sep 12, 2025
@mcremon-meta @facebook-github-bot
Add int32 quant/dequant back (#14269)
fd80b51 
Summary:
Pull Request resolved: #14269

Now that the previous diff exists, we can add the int32 case back without adding to the code size of deployed models.

Differential Revision: D82282481
@facebook-github-bot
Copy link
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82282481.

mcremon-meta added a commit that referenced this pull request Sep 12, 2025
@mcremon-meta @facebook-github-bot
Add int32 quant/dequant back (#14269)
a9bde68 
Summary:
Pull Request resolved: #14269

Now that the previous diff exists, we can add the int32 case back without adding to the code size of deployed models.

Reviewed By: hsharma35

Differential Revision: D82282481
@facebook-github-bot
Copy link
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82282481.

mcremon-meta added a commit that referenced this pull request Sep 12, 2025
@mcremon-meta @facebook-github-bot
Add int32 quant/dequant back (#14269)
1997822 
Summary:
Pull Request resolved: #14269

Now that the previous diff exists, we can add the int32 case back without adding to the code size of deployed models.

Reviewed By: hsharma35

Differential Revision: D82282481
Matthias Cremon and others added 4 commits September 14, 2025 20:30
@facebook-github-bot
Rename reference to generic and unify namespaces (#14239)
bbd00ea 
Summary:
Pull Request resolved: #14239

As titled, those operators are generic implementations of the custom ops we use, they're not reference implementations (in the numerical sense). Make the change to reflect that.

Differential Revision: D82231105

Reviewed By: ethansfng, hsharma35, DrJessop
@facebook-github-bot
Split OSS generic ops into their own dependencies
ccabd02 
Summary: As titled.

Differential Revision: D82319999
@facebook-github-bot
Introduce strongly typed quant/dequant ops (#14268)
972448e 
Summary:
Pull Request resolved: #14268

As titled.

Differential Revision: D82183474

Reviewed By: hsharma35
@mcremon-meta @facebook-github-bot
Add int32 quant/dequant back (#14269)
f5cb955 
Summary:
Pull Request resolved: #14269

Now that the previous diff exists, we can add the int32 case back without adding to the code size of deployed models.

Reviewed By: hsharma35

Differential Revision: D82282481
@facebook-github-bot
Copy link
Contributor

@mcremon-meta has exported this pull request. If you are a Meta employee, you can view the originating diff in D82282481.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsharma35 hsharma35 hsharma35 approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcremon-meta @facebook-github-bot @hsharma35