Skip to content

Unchecked Expected introduced in a28e332 #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chadrosier opened this issue Sep 12, 2019 · 2 comments
Closed

Unchecked Expected introduced in a28e332 #3504

chadrosier opened this issue Sep 12, 2019 · 2 comments

Comments

@chadrosier
Copy link
Contributor

The below commit introduced an unchecked llvm::Expected error:
Enable saturateHost in image-classifier and address a couple resulting bugs (#3443)

IIUC, the llvm::Expected introduced here:

glow/lib/LLVMIRCodeGen/LLVMCompiledFunction.cpp

Line 97 in d12d6d0

llvm::Expected<llvm::JITTargetAddress> address = NULL;

must be checked before it is overwritten here:

glow/lib/LLVMIRCodeGen/LLVMCompiledFunction.cpp

Line 104 in d12d6d0

address = sym.getAddress();

This requires an LLVM build with assertions enabled.

Would you mind taking a look @gcatron?
@chadrosier
Copy link
Contributor Author

See also: #2737

@gcatron gcatron mentioned this issue Sep 12, 2019
Closed
@gcatron
Copy link
Contributor

gcatron commented Sep 13, 2019

@chadrosier Thanks for reporting the bug, should have a fix landed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added check to llvm::expected address before overwriting it. gcatron/glow
2 participants
@gcatron @chadrosier