Skip to content

Added check to llvm::expected address before overwriting it. #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gcatron
Copy link
Contributor

@gcatron gcatron commented Sep 12, 2019

Summary:
This PR adds a check to the llvm::Expected address in llvmCompiledFunction.

Documentation:

Fixes #3504
Test Plan: ninja check.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@gcatron merged this pull request in ef7f916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unchecked Expected introduced in a28e332
3 participants