Enable saturateHost in image-classifier and address a couple resulting bugs #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcatron
force-pushed
the
image_classifier_enable_saturate_host
branch
2 times, most recently
from
19e98b0 to
68903ef
Compare
There was a problem hiding this comment.
@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jfix71
approved these changes
Aug 21, 2019
gcatron
force-pushed
the
image_classifier_enable_saturate_host
branch
from
68903ef to
51423d3
Compare
There was a problem hiding this comment.
@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables saturate host in image-classifier, so now if multiple devices are created they will be used.
As a result of this change bugs in OpenCL and CPUFunctions were exposed this PR fixes those too.
Documentation:
Test Plan: run image-classifier with num-devices >0 and backends= CPU, Interpreter, and OpenCL.