Skip to content

Enable saturateHost in image-classifier and address a couple resulting bugs #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gcatron
Copy link
Contributor

@gcatron gcatron commented Aug 21, 2019

Summary:
This PR enables saturate host in image-classifier, so now if multiple devices are created they will be used.
As a result of this change bugs in OpenCL and CPUFunctions were exposed this PR fixes those too.

Documentation:

Test Plan: run image-classifier with num-devices >0 and backends= CPU, Interpreter, and OpenCL.

@gcatron gcatron requested a review from jfix71 August 21, 2019 16:30
@gcatron gcatron force-pushed the image_classifier_enable_saturate_host branch 2 times, most recently from 19e98b0 to 68903ef Compare August 21, 2019 16:51
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@jfix71 jfix71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small comments. Thanks for fixing this!

@gcatron gcatron force-pushed the image_classifier_enable_saturate_host branch from 68903ef to 51423d3 Compare August 21, 2019 19:38
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcatron has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@gcatron merged this pull request in a28e332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants