Skip to content

[easy] Fix some dead stores #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019
Merged

[easy] Fix some dead stores #2280

merged 1 commit into from
Jan 18, 2019

Conversation

bertmaher
Copy link
Contributor

No description provided.

Copy link
Contributor

@opti-mix opti-mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -384,7 +384,7 @@ bool AvgPoolGradNode::verify() const {
isValid &= verifyPool(getGradOfInputNamedInput(),
getGradOfOriginalOutputNamedResult(), Kernels_,
Strides_, Pads_);
return true;
return isValid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is quite bad, good catch!

Copy link
Contributor

@rdzhabarov rdzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay to infer :)

@bertmaher bertmaher merged commit 1434d89 into pytorch:master Jan 18, 2019
@bertmaher bertmaher deleted the dead-store branch January 18, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants