Skip to content

[easy] Fix some dead stores #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019
Merged

[easy] Fix some dead stores #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Graph/Nodes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ bool AvgPoolGradNode::verify() const {
isValid &= verifyPool(getGradOfInputNamedInput(),
getGradOfOriginalOutputNamedResult(), Kernels_,
Strides_, Pads_);
return true;
return isValid;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is quite bad, good catch!

}

bool MatMulNode::verify() const {
Expand Down
2 changes: 1 addition & 1 deletion lib/Optimizer/IROptimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ static void calculateLiveIntervals(const IRFunction &M,
(opKind == OperandKind::Out) &&
(op->getType()->size() < loc->getType()->size());

auto opIdx = instIdx;
unsigned opIdx;
if (opKind == OperandKind::Out && !isPartialWrite) {
opIdx =
LiveIntervalsInstructionNumbering::getInstrWriteSlotNumber(instIdx);
Expand Down