Skip to content

Implement name inference rule for empty_like, clone #23746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Aug 2, 2019

Stack from ghstack:

torch.empty_like(tensor) and tensor.clone() both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the memory_format argument in the normal empty declaration
in native_functions.yaml.

Test Plan:

  • [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head

Differential Revision: D16647821

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
zou3519 added 2 commits August 6, 2019 08:35
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
Implement name inference rule for empty_like, clone

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan:
- [namedtensor ci]

gh-metadata: pytorch pytorch 23746 gh/zou3519/89/head
@zou3519 zou3519 deleted the gh/zou3519/89/head branch August 9, 2019 16:21
zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 9, 2019
Summary:
Pull Request resolved: pytorch/pytorch#23746

`torch.empty_like(tensor)` and `tensor.clone()` both propagate names to
the output tensor.

As a part of this change, I fixed the empty(..., names=) overload to
include the `memory_format` argument in the normal `empty` declaration
in native_functions.yaml.

Test Plan: - [namedtensor ci]

Differential Revision: D16647821

Pulled By: zou3519

fbshipit-source-id: 43b261f3456b6bf5fca7b6313e659b259a2ba66d
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 16b6466.

yf225 pushed a commit to yf225/pytorch that referenced this pull request Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants