-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Rename set_names -> view_names, set_names_ -> names_ #23962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci]
This was referenced Aug 7, 2019
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
This was referenced Aug 8, 2019
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
This was referenced Aug 9, 2019
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
nairbv
approved these changes
Aug 9, 2019
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
This was referenced Aug 12, 2019
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_ This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 14, 2019
Summary: Pull Request resolved: pytorch/pytorch#23962 This change should make the semantics clearer. `tensor.names_(names)` sets tensor.names to be `names`. `tensor.view_names(names)` returns a view of the tensor with names `names`. Test Plan - [namedtensor ci] Test Plan: Imported from OSS Differential Revision: D16710915 Pulled By: zou3519 fbshipit-source-id: c82fa9812624d03c86f7be84b0a460e3c047aaa0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
names
argument to ones, rand, randn, zeros, full; fix empty #24107 Addnames
argument to ones, rand, randn, zeros, full; fix emptyThis change should make the semantics clearer.
tensor.names_(names)
sets tensor.names to benames
.tensor.view_names(names)
returns a view of the tensor with namesnames
.Test Plan
Differential Revision: D16710915