Skip to content

Rename set_names -> view_names, set_names_ -> names_ #23962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Aug 7, 2019

Stack from ghstack:

This change should make the semantics clearer.

tensor.names_(names) sets tensor.names to be names.

tensor.view_names(names) returns a view of the tensor with names
names.

Test Plan

  • [namedtensor ci]

Differential Revision: D16710915

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
Rename set_names -> view_names, set_names_ -> names_

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

gh-metadata: pytorch pytorch 23962 gh/zou3519/93/head
@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in 2fcdb3a.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 14, 2019
Summary:
Pull Request resolved: pytorch/pytorch#23962

This change should make the semantics clearer.

`tensor.names_(names)` sets tensor.names to be `names`.

`tensor.view_names(names)` returns a view of the tensor with names
`names`.

Test Plan
- [namedtensor ci]

Test Plan: Imported from OSS

Differential Revision: D16710915

Pulled By: zou3519

fbshipit-source-id: c82fa9812624d03c86f7be84b0a460e3c047aaa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: internals Related to internal abstractions in c10 and ATen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants