Skip to content

[JIT] Enable NVFuser tests in CI #73322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Feb 23, 2022

Stack from ghstack:

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: D34436844

These tests have been disabled in OSS CI since #34785.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 23, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/8e62ca8d90b58f07ae31eccf9ab0ce7a90d02d6e/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
linux-binary-manywheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/default, ciflow/linux, ciflow/rocm, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-arm64-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-arm64-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
macos-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
windows-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk, ciflow/xla 🚫 skipped

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 23, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 54966e9 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️‍♀️ 2 failures not recognized by patterns:

The following CI failures may be due to changes from the PR
Job Step Action
GitHub Actions pull / linux-bionic-rocm5.0-py3.7 / test (default, 2, 2, linux.rocm.gpu) Checkout PyTorch 🔁 rerun
GitHub Actions pull / linux-bionic-rocm5.0-py3.7 / test (default, 1, 2, linux.rocm.gpu) Checkout PyTorch 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

davidberard98 added a commit that referenced this pull request Feb 23, 2022
These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 9d3b218
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98 davidberard98 changed the title [JIT] Enable NVFuser tests in OSS CI [JIT] Enable NVFuser tests in CI Feb 24, 2022
davidberard98 added a commit that referenced this pull request Feb 24, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 67e2653
Pull Request resolved: #73322
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Feb 24, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 2af9f7e
Pull Request resolved: #73322
@davidberard98 davidberard98 linked an issue Feb 24, 2022 that may be closed by this pull request
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Feb 25, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 95a0cfb
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Feb 25, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 380e98c
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Feb 25, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 0e54067
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Feb 26, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: 9b80ac8
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Mar 1, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: befd4c0
Pull Request resolved: #73322
These tests have been disabled in OSS CI since #34785.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Mar 2, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: d4d312c
Pull Request resolved: #73322
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

These tests have been disabled in OSS CI since #34785.

This disables the windows tests, which currently aren't passing.

Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844)

[ghstack-poisoned]
@davidberard98
Copy link
Contributor Author

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! LGTM - @jjsjann123 may want to look over as well

@@ -588,7 +595,8 @@ def test_unary_ops(self):
self._unary_test_helper(op, dtype, False) # test special numbers
self._unary_test_helper(op, dtype, True) # test random data

@unittest.skipIf(not RUN_CUDA, "requires CUDA")
@unittest.skipIf(True, "See issues 73395 and 75029")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm.. I don't remember seeing test failures in my last upstream push. let me take a look here.

Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks fine. Let's merge this one.
I can double check the failing tests afterwards.

facebook-github-bot pushed a commit that referenced this pull request Apr 1, 2022
Summary:
Pull Request resolved: #73322

These tests have been disabled in OSS CI since #34785.

Test Plan: Imported from OSS

Reviewed By: eellison

Differential Revision: D34436844

Pulled By: davidberard98

fbshipit-source-id: c5b14b33e7f369a6fa1e9cfbcb484a30dffc659e
davidberard98 added a commit that referenced this pull request Apr 1, 2022
fixes merge issue between #75016 and #73322

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Apr 1, 2022
fixes merge issue between #75016 and #73322

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Apr 1, 2022
fixes merge issue between #75016 and #73322

ghstack-source-id: a79f74a
Pull Request resolved: #75134
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/52/head branch April 5, 2022 14:17
NesrineMHB pushed a commit to NesrineMHB/pytorch that referenced this pull request Apr 8, 2022
1) remove test_jit_cuda_fuser from list of disabled tests
2) make the tests run on cpu (skip the tests instead of erroring)

These tests have been disabled in OSS CI since #34785.

ghstack-source-id: e64ec0b
Pull Request resolved: pytorch/pytorch#73322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nvfuser tests to CI
5 participants