-
Notifications
You must be signed in to change notification settings - Fork 24.2k
[JIT] Enable NVFuser tests in CI #73322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These tests have been disabled in OSS CI since #34785. [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 54966e9 (more details on the Dr. CI page):
🕵️♀️ 2 failures not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
These tests have been disabled in OSS CI since #34785. [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
These tests have been disabled in OSS CI since #34785. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These tests have been disabled in OSS CI since #34785. This disables the windows tests, which currently aren't passing. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. This disables the windows tests, which currently aren't passing. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. This disables the windows tests, which currently aren't passing. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. This disables the windows tests, which currently aren't passing. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
These tests have been disabled in OSS CI since #34785. This disables the windows tests, which currently aren't passing. Differential Revision: [D34436844](https://our.internmc.facebook.com/intern/diff/D34436844) [ghstack-poisoned]
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! LGTM - @jjsjann123 may want to look over as well
@@ -588,7 +595,8 @@ def test_unary_ops(self): | |||
self._unary_test_helper(op, dtype, False) # test special numbers | |||
self._unary_test_helper(op, dtype, True) # test random data | |||
|
|||
@unittest.skipIf(not RUN_CUDA, "requires CUDA") | |||
@unittest.skipIf(True, "See issues 73395 and 75029") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm.. I don't remember seeing test failures in my last upstream push. let me take a look here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change looks fine. Let's merge this one.
I can double check the failing tests afterwards.
1) remove test_jit_cuda_fuser from list of disabled tests 2) make the tests run on cpu (skip the tests instead of erroring) These tests have been disabled in OSS CI since #34785. ghstack-source-id: e64ec0b Pull Request resolved: pytorch/pytorch#73322
Stack from ghstack:
These tests have been disabled in OSS CI since #34785.
This disables the windows tests, which currently aren't passing.
Differential Revision: D34436844