Skip to content

move //tools/codegen:codegen into shared build structure #74386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 34 commits into from

Conversation

This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 17, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit b580e89 (more details on the Dr. CI page):


  • 4/4 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / build (1/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:26:53.1676547Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m
2022-03-30T19:26:53.1673536Z �[36;1mfi�[0m
2022-03-30T19:26:53.1673778Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:26:53.1674136Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:26:53.1674465Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:26:53.1674828Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:26:53.1675126Z �[36;1m  exit 1�[0m
2022-03-30T19:26:53.1675298Z �[36;1mfi�[0m
2022-03-30T19:26:53.1675531Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:26:53.1675878Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:26:53.1676200Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:26:53.1676547Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:26:53.1676895Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:26:53.1677221Z �[36;1m  exit 1�[0m
2022-03-30T19:26:53.1677396Z �[36;1mfi�[0m
2022-03-30T19:26:53.1677591Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:26:53.1688326Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:26:53.1688557Z env:
2022-03-30T19:26:53.1688709Z   IN_CI: 1
2022-03-30T19:26:53.1688879Z   IS_GHA: 1
2022-03-30T19:26:53.1689101Z   BASE_REVISION: a05d981a52653e3d0155a93258ea6d7422fd90c1
2022-03-30T19:26:53.1689521Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (2/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:26:50.9703892Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m
2022-03-30T19:26:50.9700737Z �[36;1mfi�[0m
2022-03-30T19:26:50.9700994Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:26:50.9701365Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:26:50.9701704Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:26:50.9702077Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:26:50.9702387Z �[36;1m  exit 1�[0m
2022-03-30T19:26:50.9702581Z �[36;1mfi�[0m
2022-03-30T19:26:50.9702832Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:26:50.9703191Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:26:50.9703527Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:26:50.9703892Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:26:50.9704377Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:26:50.9704639Z �[36;1m  exit 1�[0m
2022-03-30T19:26:50.9704832Z �[36;1mfi�[0m
2022-03-30T19:26:50.9705045Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:26:50.9715909Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:26:50.9716157Z env:
2022-03-30T19:26:50.9716334Z   IN_CI: 1
2022-03-30T19:26:50.9716523Z   IS_GHA: 1
2022-03-30T19:26:50.9716734Z   GIT_DEFAULT_BRANCH: master
2022-03-30T19:26:50.9716981Z   BASE_REVISION: a05d981a52653e3d0155a93258ea6d7422fd90c1

See GitHub Actions build pull / deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build (3/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T19:26:41.1686709Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m
2022-03-30T19:26:41.1683855Z �[36;1mfi�[0m
2022-03-30T19:26:41.1684077Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T19:26:41.1684414Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T19:26:41.1684723Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T19:26:41.1685062Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T19:26:41.1685340Z �[36;1m  exit 1�[0m
2022-03-30T19:26:41.1685502Z �[36;1mfi�[0m
2022-03-30T19:26:41.1685719Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T19:26:41.1686043Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T19:26:41.1686345Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T19:26:41.1686709Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T19:26:41.1687091Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T19:26:41.1687384Z �[36;1m  exit 1�[0m
2022-03-30T19:26:41.1687546Z �[36;1mfi�[0m
2022-03-30T19:26:41.1687727Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T19:26:41.1697788Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T19:26:41.1698001Z env:
2022-03-30T19:26:41.1698143Z   IN_CI: 1
2022-03-30T19:26:41.1698301Z   IS_GHA: 1
2022-03-30T19:26:41.1698511Z   BASE_REVISION: a05d981a52653e3d0155a93258ea6d7422fd90c1
2022-03-30T19:26:41.1698906Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

1 failure not recognized by patterns:

Job Step Action
GitHub Actions pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) Test 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 17, 2022

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/7a5ea7569c40e673b11694ae7abb2ec1b567755c/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default
Add ciflow labels to this PR to trigger more builds:

Workflows Labels (bold enabled) Status
Triggered Workflows
deploy-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
linux-binary-libtorch-cxx11-abi ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
linux-binary-libtorch-pre-cxx11 ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
linux-binary-manywheel ciflow/all, ciflow/binaries, ciflow/binaries_wheel, ciflow/default, ciflow/trunk ✅ triggered
linux-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/trunk ✅ triggered
linux-bionic-rocm4.5-py3.7 ciflow/all, ciflow/default, ciflow/linux, ciflow/rocm, ciflow/trunk ✅ triggered
linux-docs ciflow/all, ciflow/cpu, ciflow/default, ciflow/docs, ciflow/linux, ciflow/trunk ✅ triggered
linux-vulkan-bionic-py3.7-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers, ciflow/trunk ✅ triggered
linux-xenial-py3.7-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc5.4-mobile-lightweight-dispatch-build ciflow/all, ciflow/cpu, ciflow/default, ciflow/libtorch, ciflow/linux, ciflow/mobile, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
linux-xenial-py3.7-gcc7-no-ops ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
macos-arm64-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-arm64-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
macos-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
macos-binary-libtorch-cxx11-abi ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-libtorch-pre-cxx11 ciflow/binaries, ciflow/binaries_libtorch, ciflow/default ✅ triggered
macos-binary-wheel ciflow/binaries, ciflow/binaries_wheel, ciflow/default ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit ciflow/all, ciflow/android, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/trunk ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/trunk, ciflow/win ✅ triggered
windows-binary-conda ciflow/binaries, ciflow/binaries_conda, ciflow/default ✅ triggered
windows-binary-libtorch-debug ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
windows-binary-libtorch-release ciflow/all, ciflow/binaries, ciflow/binaries_libtorch, ciflow/default, ciflow/trunk ✅ triggered
windows-binary-wheel ciflow/all, ciflow/binaries, ciflow/binaries_wheel, ciflow/default, ciflow/trunk ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
docker-builds ciflow/all, ciflow/trunk 🚫 skipped
ios-12-5-1-arm64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-custom-ops ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-arm64-metal ciflow/all, ciflow/ios, ciflow/macos, ciflow/scheduled 🚫 skipped
ios-12-5-1-x86-64 ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
ios-12-5-1-x86-64-coreml ciflow/all, ciflow/ios, ciflow/macos, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/trunk 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow, ciflow/trunk 🚫 skipped
linux-bionic-rocm4.5-py3.7-distributed ciflow/all, ciflow/linux, ciflow/rocm, ciflow/trunk 🚫 skipped
linux-docs-push ciflow/all, ciflow/cpu, ciflow/linux, ciflow/scheduled 🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops ciflow/all, ciflow/cuda, ciflow/linux, ciflow/trunk 🚫 skipped
macos-10-15-py3-arm64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
macos-11-py3-x86-64 ciflow/all, ciflow/macos, ciflow/trunk 🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.3-py3.7-gcc7-debug ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.5-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build ciflow/all, ciflow/android, ciflow/cpu, ciflow/linux, ciflow/trunk 🚫 skipped
pytorch-xla-linux-bionic-py3.7-clang8 ciflow/all, ciflow/cpu, ciflow/linux, ciflow/trunk, ciflow/xla 🚫 skipped

dagitses pushed a commit that referenced this pull request Mar 17, 2022
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

ghstack-source-id: 151649215
Pull Request resolved: #74386
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits March 21, 2022 07:45
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 5 commits March 21, 2022 09:32
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 7 commits March 24, 2022 05:21
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits March 25, 2022 03:58
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 7 commits March 25, 2022 09:27
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 3 commits March 28, 2022 12:15
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
This is currently only used by Buck.

Differential Revision: [D34971529](https://our.internmc.facebook.com/intern/diff/D34971529/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34971529/)!

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2022
Summary:
Pull Request resolved: #74386

This is currently only used by Buck.
ghstack-source-id: 152438661

Test Plan: Rely on CI.

Reviewed By: malfet

Differential Revision: D34971529

fbshipit-source-id: 2e0f1c84c46bd659ae8ab90b266a478775f7b0da
@facebook-github-bot facebook-github-bot deleted the gh/dagitses/291/head branch April 3, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants