Skip to content

[quant][fx] Remove additional_object_mapping from the docs #75389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Apr 6, 2022

Stack from ghstack (oldest at bottom):

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D35451960

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e304407 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-11T06:36:16.3241597Z RuntimeError: tens...OK() (UNKNOWN: Could not start gRPC server vs. OK)
2022-04-11T06:36:16.3234594Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 315, in _setup_replication
2022-04-11T06:36:16.3235150Z     device = xm.xla_device()
2022-04-11T06:36:16.3235652Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 232, in xla_device
2022-04-11T06:36:16.3237154Z     devkind=devkind if devkind is not None else None)
2022-04-11T06:36:16.3238199Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 137, in get_xla_supported_devices
2022-04-11T06:36:16.3238842Z     xla_devices = _DEVICES.value
2022-04-11T06:36:16.3239319Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/utils/utils.py", line 32, in value
2022-04-11T06:36:16.3239739Z     self._value = self._gen_fn()
2022-04-11T06:36:16.3240372Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/core/xla_model.py", line 19, in <lambda>
2022-04-11T06:36:16.3240926Z     _DEVICES = xu.LazyProperty(lambda: torch_xla._XLAC._xla_get_devices())
2022-04-11T06:36:16.3241597Z RuntimeError: tensorflow/compiler/xla/xla_client/xrt_local_service.cc:56 : Check failed: tensorflow::NewServer(server_def, &server_) == ::tensorflow::Status::OK() (UNKNOWN: Could not start gRPC server vs. OK)
2022-04-11T06:36:16.3247199Z xla:0 is not a TPU or GPU device
2022-04-11T06:36:16.5294248Z Traceback (most recent call last):
2022-04-11T06:36:16.5294839Z   File "/var/lib/jenkins/workspace/xla/test/test_mp_all_gather.py", line 49, in <module>
2022-04-11T06:36:16.5295311Z     xmp.spawn(_mp_fn, args=())
2022-04-11T06:36:16.5295869Z   File "/opt/conda/lib/python3.7/site-packages/torch_xla-1.12-py3.7-linux-x86_64.egg/torch_xla/distributed/xla_multiprocessing.py", line 395, in spawn
2022-04-11T06:36:16.5296197Z     start_method=start_method)
2022-04-11T06:36:16.5296578Z   File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 198, in start_processes
2022-04-11T06:36:16.5296849Z     while not context.join():
2022-04-11T06:36:16.5297205Z   File "/opt/conda/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 154, in join
2022-04-11T06:36:16.5297469Z     exit_code=exitcode

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jerryzh168 added a commit that referenced this pull request Apr 6, 2022
Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 821814f
Pull Request resolved: #75389
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jerryzh168 jerryzh168 requested a review from vkuzo April 6, 2022 23:40
@jerryzh168 jerryzh168 added release notes: quantization release notes category topic: bc breaking topic category labels Apr 6, 2022
@jerryzh168 jerryzh168 requested a review from andrewor14 April 6, 2022 23:47
@jerryzh168 jerryzh168 changed the title [quant][fx] Remove additional_object_mapping from the docs [quant][fx][bc-breaking] Remove additional_object_mapping from the docs Apr 6, 2022
…from the docs"

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
…from the docs"

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jerryzh168 jerryzh168 added topic: not user facing topic category and removed release notes: quantization release notes category topic: bc breaking topic category labels Apr 8, 2022
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can update the PR title too?

@jerryzh168 jerryzh168 changed the title [quant][fx][bc-breaking] Remove additional_object_mapping from the docs [quant][fx] Remove additional_object_mapping from the docs Apr 8, 2022
Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary:
This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35451960](https://our.internmc.facebook.com/intern/diff/D35451960)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 11, 2022
Summary:
Pull Request resolved: #75389

This seems to be removed before, so won't mark this PR as bc-breaking, this use case
is now enabled with backend_config_dict api

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps

Imported from OSS

Reviewed By: vkuzo

Differential Revision: D35451960

fbshipit-source-id: 21a8f19c1968af44bf4fa603f16ee8c6f5080e5a
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/782/head branch April 14, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants