[quant][fx] Cleanup some unused states and args #75521

jerryzh168 · 2022-04-08T16:26:34Z

Stack from ghstack (oldest at bottom):

-> [quant][fx] Cleanup some unused states and args #75521

Summary:

Removed "patterns" from observed module since it's no longer needed
Removed an arg from insert_observer

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestQuantizeFxModels

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D35502220

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

facebook-github-bot · 2022-04-08T16:26:41Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75521
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 265d275 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

jerryzh168 · 2022-04-08T16:43:54Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b542b31 Pull Request resolved: #75521

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8c8dd73 Pull Request resolved: #75521

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 924a636 Pull Request resolved: #75521

jerryzh168 · 2022-04-09T07:30:47Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer * Removed some unused keys in checking the validity of qconfig_dict Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 24728a5 Pull Request resolved: #75521

jerryzh168 · 2022-04-11T06:19:05Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer * Removed some unused keys in checking the validity of qconfig_dict Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cc1b9a3 Pull Request resolved: #75521

jerryzh168 · 2022-04-12T04:33:39Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer * Removed some unused keys in checking the validity of qconfig_dict Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9f8c80c Pull Request resolved: #75521

jerryzh168 · 2022-04-13T03:07:38Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer * Removed some unused keys in checking the validity of qconfig_dict Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 37d1566 Pull Request resolved: #75521

jerryzh168 · 2022-04-13T06:47:09Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35502220](https://our.internmc.facebook.com/intern/diff/D35502220) [ghstack-poisoned]

Summary: * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer * Removed some unused keys in checking the validity of qconfig_dict Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 05f2079 Pull Request resolved: #75521

jerryzh168 · 2022-04-13T18:50:50Z

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-04-14T00:55:22Z

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-04-14T00:56:50Z

Merge failed due to Refusing to merge as mandatory check Lint failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2164563956

malfet · 2022-04-14T01:40:48Z

Hmm, somehow there are no lint workflow ever scheduled for this PR(Lint workflow for previous iteration of this PR were cancelled and never scheduled for this one, manually scheduling it now)...

malfet · 2022-04-14T13:16:45Z

@pytorchbot merge this

github-actions · 2022-04-14T13:18:42Z

Hey @jerryzh168.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #75521 * Removed "patterns" from observed module since it's no longer needed * Removed an arg from insert_observer Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestQuantizeFxModels Imported from OSS Reviewed By: andrewor14 Differential Revision: D35502220 fbshipit-source-id: 968888c15ffc7084b8aab60429a3c34990876782

facebook-github-bot added the cla signed label Apr 8, 2022

This was referenced Apr 8, 2022

[qunat][fx] Remove "additional_qat_mapping" key from prepare_custom_config_dict #75387

Closed

[qunat][fx] Remove "additional_fuser_method_mapping" key from prepare_custom_config_dict #75388

Closed

facebook-github-bot added the module: fx label Apr 8, 2022

This was referenced Apr 8, 2022

[quant][fx] Remove additional_object_mapping from the docs #75389

Closed

[quant][fx] Using native backend_config_dict in prepare #75469

Closed

[quant][fx] Use native backend_config_dict in convert #75520

Closed

jerryzh168 requested review from vkuzo and andrewor14 April 8, 2022 16:35

andrewor14 approved these changes Apr 8, 2022

View reviewed changes

pytorchmergebot closed this in 0c08fcf Apr 14, 2022

jerryzh168 mentioned this pull request Apr 14, 2022

[quant][fx] Move backend_config folder to torch.ao.quantization #75823

Closed

facebook-github-bot deleted the gh/jerryzh168/785/head branch April 17, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[quant][fx] Cleanup some unused states and args #75521

[quant][fx] Cleanup some unused states and args #75521

Uh oh!

jerryzh168 commented Apr 8, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 8, 2022 •

edited

Loading

Uh oh!

jerryzh168 commented Apr 8, 2022

Uh oh!

jerryzh168 commented Apr 9, 2022

Uh oh!

jerryzh168 commented Apr 11, 2022

Uh oh!

jerryzh168 commented Apr 12, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

facebook-github-bot commented Apr 14, 2022

Uh oh!

pytorchmergebot commented Apr 14, 2022

Uh oh!

malfet commented Apr 14, 2022 •

edited

Loading

Uh oh!

malfet commented Apr 14, 2022

Uh oh!

github-actions bot commented Apr 14, 2022

Uh oh!

Uh oh!

[quant][fx] Cleanup some unused states and args #75521

[quant][fx] Cleanup some unused states and args #75521

Uh oh!

Conversation

jerryzh168 commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

jerryzh168 commented Apr 8, 2022

Uh oh!

jerryzh168 commented Apr 9, 2022

Uh oh!

jerryzh168 commented Apr 11, 2022

Uh oh!

jerryzh168 commented Apr 12, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

jerryzh168 commented Apr 13, 2022

Uh oh!

facebook-github-bot commented Apr 14, 2022

Uh oh!

pytorchmergebot commented Apr 14, 2022

Uh oh!

malfet commented Apr 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malfet commented Apr 14, 2022

Uh oh!

github-actions bot commented Apr 14, 2022

Uh oh!

Uh oh!

jerryzh168 commented Apr 8, 2022 •

edited

Loading

facebook-github-bot commented Apr 8, 2022 •

edited

Loading

malfet commented Apr 14, 2022 •

edited

Loading