Added remove_duplicate parameter to nn.Module (#6)
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33716716 |
Chillee
added a commit
to Chillee/torchrec
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: 35152634fba5cb475441a7bb0f00b524a7b1f98e
Chillee
force-pushed
the
export-D33716716
branch
from
561ad47 to
46280e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33716716 |
Chillee
added a commit
to Chillee/torchrec
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: d1134e2f7cc62ac45fb9c17ecdca5e993c9c34ed
Chillee
force-pushed
the
export-D33716716
branch
from
46280e5 to
9b42ca5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33716716 |
Chillee
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: #71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: 364b70a203fe4b004240a361e31006029ae9f907
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: f5e25ed5411d0ea46d3bca5c4f942bb57bc5801d
Chillee
added a commit
to Chillee/torchrec
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: e872ead070dad515ac51ab16c65ae87386cce7a4
Chillee
force-pushed
the
export-D33716716
branch
from
9b42ca5 to
b36710a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D33716716 |
Chillee
added a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: #71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: 8ae09a9fb8bf69d08d9a23cc3bc7e61c4ed826b3
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: #39 Pull Request resolved: #6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: #71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 1, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: #71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213 (cherry picked from commit d6e3ad3)
|
This pull request has been reverted by 8c6ee8a. |
|
This pull request has been reverted by f40e1f0bb01fb3d73955e752edb24b7cc958dcf6. |
|
This pull request has been reverted by b3a589bab9f71597632b313ca9bbc14c8199199b. |
|
This pull request has been reverted by 7cdbbfaee20fe84bded0d1df3307bd7e8b5090e4. |
1 similar comment
|
This pull request has been reverted by 7cdbbfaee20fe84bded0d1df3307bd7e8b5090e4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #6
This makes it so that shared parameters get their own entry in
named_parameters.More broadly, this makes it so that
is identical to calling the original module's forwards pass.
cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang
Pull Request resolved: pytorch/pytorch#71542
Reviewed By: jbschlosser, albanD
Differential Revision: D33716716
Pulled By: Chillee