col-wise ads config #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31058649 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D31058649 |
YazhiGao
force-pushed
the
export-D31058649
branch
from
7523aed to
214e2f9
Compare
facebook-github-bot
added
the
CLA Signed
YazhiGao
force-pushed
the
export-D31058649
branch
from
214e2f9 to
217472f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31058649 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D31058649 |
YazhiGao
force-pushed
the
export-D31058649
branch
from
217472f to
05b1a03
Compare
Summary: Pull Request resolved: pytorch/torchrec#6 Reviewed By: dstaay-fb Differential Revision: D31058649 fbshipit-source-id: 42615d95dc2b6a59b542340986ca63767600abe6
YazhiGao
force-pushed
the
export-D31058649
branch
from
05b1a03 to
fab133b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31058649 |
YazhiGao
pushed a commit
to YazhiGao/torchrec-2
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: pytorch/pytorch#71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213
peterbell10
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Feb 24, 2022
Summary: Pull Request resolved: pytorch/torchrec#39 Pull Request resolved: pytorch/torchrec#6 This makes it so that shared parameters get their own entry in `named_parameters`. More broadly, this makes it so that ``` params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)} _stateless.functional_call(mod, params_and_buffers, args, kwargs) ``` is identical to calling the original module's forwards pass. cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang Pull Request resolved: #71542 Reviewed By: jbschlosser, albanD Differential Revision: D33716716 Pulled By: Chillee fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213 (cherry picked from commit d6e3ad3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: column-wise sharding for ads 10x model
Differential Revision: D31058649