Skip to content

Make CircleCI checkout merge commit #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Sep 17, 2019

This makes tests run not on the PR branch, but the PR branch rebased on top of master instead.
This is safer because the tests now signal the status of master if a PR gets merged.

@fmassa fmassa requested review from ezyang and soumith September 17, 2019 12:44
Copy link
Member

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you tried it locally and you are getting the merge commit, go for it!

@codecov-io
Copy link

Codecov Report

Merging #1344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1344   +/-   ##
=======================================
  Coverage   65.59%   65.59%           
=======================================
  Files          75       75           
  Lines        5819     5819           
  Branches      892      892           
=======================================
  Hits         3817     3817           
  Misses       1735     1735           
  Partials      267      267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4392a8...4f01a05. Read the comment docs.

@fmassa fmassa merged commit ef6d6c4 into pytorch:master Sep 17, 2019
@fmassa fmassa deleted the circleci-checkout-merge branch September 17, 2019 14:13
@fmassa fmassa mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants