Skip to content

Fix nightly builds #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2019
Merged

Fix nightly builds #1374

merged 5 commits into from
Sep 26, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Sep 26, 2019

Nightly builds on master have been failing after #1344 got merged with error

#!/bin/bash -eo pipefail
set -ex
git fetch --force origin ${CIRCLE_BRANCH}/merge:merged/${CIRCLE_BRANCH}
git checkout "merged/$CIRCLE_BRANCH"
+ git fetch --force origin master/merge:merged/master
fatal: Couldn't find remote ref master/merge
Killed by signal 1.

Exited with code 128

because the PR assumed that CI would only run on PR branches.
This PR skips rebasing if CI is run on master.

@fmassa fmassa requested review from ezyang and soumith September 26, 2019 16:08
@fmassa
Copy link
Member Author

fmassa commented Sep 26, 2019

Test failures are unrelated. It seems that Travis CI has less CPU memory than CircleCI (for the machines we are using). Those failing tests should be disabled on Travis

@fmassa
Copy link
Member Author

fmassa commented Sep 26, 2019

cc @stephenyan1231 for the failures on video_reader. It looks like the tests are using too much CPU memory for Travis.

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0982395). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1374   +/-   ##
=========================================
  Coverage          ?   63.83%           
=========================================
  Files             ?       78           
  Lines             ?     6147           
  Branches          ?      940           
=========================================
  Hits              ?     3924           
  Misses            ?     1945           
  Partials          ?      278
Impacted Files Coverage Δ
torchvision/datasets/utils.py 62.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0982395...1cbc9e7. Read the comment docs.

@soumith soumith merged commit cae0eee into pytorch:master Sep 26, 2019
@fmassa fmassa deleted the fix-nightly-build branch September 26, 2019 20:07
ekagra-ranjan added a commit to ekagra-ranjan/vision that referenced this pull request Sep 26, 2019
ekagra-ranjan added a commit to ekagra-ranjan/vision that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants