Skip to content

Added CPU/CUDA and batch input for dtype conversion op #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 5, 2020

Description:

  • Improved tests of ConvertImageDtype

Blocked by #2485

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #2755 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2755   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files          96       96           
  Lines        8319     8319           
  Branches     1293     1293           
=======================================
  Hits         6080     6080           
  Misses       1840     1840           
  Partials      399      399           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d87296...275c2b2. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2485 has been merged, should we rebase on top of master now?

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit fdca307 into pytorch:master Oct 5, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* make convert_image_dtype scriptable

* move convert dtype to functional_tensor since only works on tensors

* retain availability of convert_image_dtype in functional.py

* Update code and tests

* Replaced int by torch.dtype

* int -> torch.dtype and use F instead of F_t

* Update functional_tensor.py

* Added CPU/CUDA+batch tests

* Fixed tests according to review

Co-authored-by: Brian <[email protected]>
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
* make convert_image_dtype scriptable

* move convert dtype to functional_tensor since only works on tensors

* retain availability of convert_image_dtype in functional.py

* Update code and tests

* Replaced int by torch.dtype

* int -> torch.dtype and use F instead of F_t

* Update functional_tensor.py

* Added CPU/CUDA+batch tests

* Fixed tests according to review

Co-authored-by: Brian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants