Fix ops registration on windows #3380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3380 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 105 105
Lines 9716 9716
Branches 1561 1561
=======================================
Hits 7268 7268
Misses 1961 1961
Partials 487 487 Continue to review full report at Codecov.
|
|
Ordinarily I'd have concerns about the portability of linker pragmas, but since this is MSVC only this probably is OK. @fmassa at the end of the day it's your call, but this also looks somewhat plausible. |
|
Yes I tried multiple things before settling on the linker pragma, but none quite worked. On the plus side, this code can be removed if/when torchvision will require C++17. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 12, 2021
Summary: * On MSVC, instruct the linker not to drop the _register_ops symbol * Remove workaround for ops registration on windows Reviewed By: mthrok Differential Revision: D26422438 fbshipit-source-id: 7560e2a00c395a44090327446c2616328823a8fc Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that on windows, a
__declspec(selectany)variable is not the same as a C++17 inline variable.I have therefore added a linker instruction to force the inclusion of the weak symbol.