Port normalize, linear_transformation, compose, random_apply, gaussian_blur to pytest #4023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vivekkumar7089 ! from a quick look it looks like there were some merging issues: I see no deleted tested, and it seems that there are tests like Would you mind fixing these? |
|
@NicolasHug, I will fix them out. |
NicolasHug
reviewed
Jun 9, 2021
test/test_transforms_tensor.py
Outdated
| torch.manual_seed(12) | ||
| transformed_tensor_script = scripted_fn(tensor) | ||
| assert_equal(transformed_tensor, transformed_tensor_script, msg="{}".format(transforms)) | ||
| def test_five_crop(self): |
There was a problem hiding this comment.
I think this (and some other tests) should be left out, as they've been ported to pytest already
|
Hi @NicolasHug !! |
NicolasHug
approved these changes
Jun 9, 2021
|
Hey @NicolasHug! You approved or merged this PR, but no labels were added. |
6 tasks
|
Good bot! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
…, gaussian_blur to pytest (#4023) Reviewed By: fmassa Differential Revision: D29097715 fbshipit-source-id: 4e6b3a8f5fc82f45bd89223f86adb077be9ab576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Group E as mentioned in #3987