Added typing annotations to models/video #4229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Same here @fmassa, the failed test looks unrelated, ready for review 👌 |
datumbox
reviewed
Aug 16, 2021
| zero_init_residual=False): | ||
| def __init__( | ||
| self, | ||
| block: Type[Union[BasicBlock, Bottleneck]], |
There was a problem hiding this comment.
I believe block should be an nn.Module. The intention is to allow users pass their own custom blocks
There was a problem hiding this comment.
Alright, but apart from nn.Module default class, it needs an expansion attribute
There was a problem hiding this comment.
You are right, leave as is. :)
There was a problem hiding this comment.
Suggested change
| block: Type[Union[BasicBlock, Bottleneck]], | |
| block: Callable[..., Union[BasicBlock, Bottleneck]], |
datumbox
reviewed
Aug 23, 2021
|
@datumbox Any clue about the reason of this failure? |
datumbox
reviewed
Aug 23, 2021
| zero_init_residual=False): | ||
| def __init__( | ||
| self, | ||
| block: Type[Union[BasicBlock, Bottleneck]], |
There was a problem hiding this comment.
Suggested change
| block: Type[Union[BasicBlock, Bottleneck]], | |
| block: Callable[..., Union[BasicBlock, Bottleneck]], |
datumbox
reviewed
Aug 23, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 26, 2021
Summary: * style: Added typing to models/video * style: Fixed typing * style: Fixed typing * style: Fixed typing * refactor: Removed default value for stem * docs: Fixed docstring of VideoResNet * style: Refactored typing * docs: Fixed docstring * style: Fixed typing * docs: Specified docstring * typing: Fixed tying * docs: Fixed docstring * Undoing change. Reviewed By: fmassa Differential Revision: D30525888 fbshipit-source-id: 0015be22677c06f07d5d8f3c2e46fe05c2a455e4
NicolasHug
added
code quality
module: video
module: models
and removed
module: video
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2025, this PR adds missing typing annotations in
models/video.Any feedback is welcome!
cc @datumbox