Setting seeds for test_batched_nms_implementations #4766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 16ffae3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
14 tasks
|
Awesome! Now we know this is due to the unstable sort. We actually get duplicate scores: Changing to stable sort might help but we had been facing issues while trying to do it: #4491 Might worth putting more time on it. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
Summary: * adding multiweight support for deeplabv3 prototype models * adding default values for optional params * fixing bug * addressing PR comment * fixing seed in test_batched_nms_implementations * change seeds in test_batched_nms_implementations * change seeds in test_batched_nms_implementations Reviewed By: datumbox Differential Revision: D32064711 fbshipit-source-id: f88cac21cb8a906237a9ef26bb53acca047dcace
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* adding multiweight support for deeplabv3 prototype models * adding default values for optional params * fixing bug * addressing PR comment * fixing seed in test_batched_nms_implementations * change seeds in test_batched_nms_implementations * change seeds in test_batched_nms_implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4506
Checked locally 10k seeds and observed 6 fails: 1759, 3698, 3813, 4417, 8600, 8969
I am fixing the seed to avoid failures in the future despite they are seemingly rare.
cc @pmeier