Skip to content

Setting seeds for test_batched_nms_implementations #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 28, 2021
Merged

Setting seeds for test_batched_nms_implementations #4766

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d1023bb
adding multiweight support for deeplabv3 prototype models
jdsgomes Oct 27, 2021
e1f25d1
adding default values for optional params
jdsgomes Oct 27, 2021
9e9905f
fixing bug
jdsgomes Oct 27, 2021
81e888d
addressing PR comment
jdsgomes Oct 27, 2021
e826f57
fixing seed in test_batched_nms_implementations
jdsgomes Oct 27, 2021
7dbd7f9
Merge branch 'main' into tests/flaky_batched_nms
jdsgomes Oct 27, 2021
c5a4a8e
Merge branch 'main' into tests/flaky_batched_nms
jdsgomes Oct 27, 2021
7767b35
Merge branch 'main' into tests/flaky_batched_nms
jdsgomes Oct 27, 2021
cd68508
change seeds in test_batched_nms_implementations
jdsgomes Oct 28, 2021
dcf1eba
change seeds in test_batched_nms_implementations
jdsgomes Oct 28, 2021
16ffae3
Merge branch 'main' into tests/flaky_batched_nms
jdsgomes Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,8 +557,10 @@ def test_nms_cuda_float16(self):
keep16 = ops.nms(boxes.to(torch.float16), scores.to(torch.float16), iou_thres)
assert_equal(keep32, keep16)

def test_batched_nms_implementations(self):
@pytest.mark.parametrize("seed", range(10))
def test_batched_nms_implementations(self, seed):
"""Make sure that both implementations of batched_nms yield identical results"""
torch.random.manual_seed(seed)

num_boxes = 1000
iou_threshold = 0.9
Expand Down