Skip to content

add padding-mode choice to RandomCrop #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

add padding-mode choice to RandomCrop #512

merged 1 commit into from
May 24, 2018

Conversation

jxgu1016
Copy link
Contributor

In torch, RandomCrop can set padding mode but in PyTorch we cannot. So I think this feature may help many researchers including me!

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fmassa fmassa merged commit 11da4f1 into pytorch:master May 24, 2018
@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 24, 2018

@fmassa I think the PR #489 has already handled this problem too and fixed some other problems

@fmassa
Copy link
Member

fmassa commented May 24, 2018

Indeed, looks like this patch is a subset of #489 that I have missed.
I'm reverting this and will merge #489 then

fmassa added a commit that referenced this pull request May 24, 2018
fmassa added a commit that referenced this pull request May 24, 2018
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
varunagrawal pushed a commit to varunagrawal/vision that referenced this pull request Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants