-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Fix DTD prototype dataset on Windows #5227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 3159f66 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Job | Step | Action |
---|---|---|
curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh | ||
sh conda.sh -b | ||
source $HOME/miniconda3/bin/activate | ||
conda install -yq conda-build cmake | ||
packaging/build_cmake.sh | ||
🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
This reverts commit f53cf60.
Turns out, this is actually an issue in |
With my fix in pytorch/data#174, we do not need to care about the line endings while generating or reading the files. Thus, this PR only fixes the mock data generation of DTD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmeier
Summary: * [DEBUG] run prototype tests on Windows * disable duplicate resource class * fix newlines in mock data generation * fix path matching for DTD * revert CI changes * Revert "fix newlines in mock data generation" This reverts commit f53cf60. * rerun tests with fix in torchdata * revert CI changes * add explanation Reviewed By: kazhang Differential Revision: D33927486 fbshipit-source-id: 6242128b812f2c797b9c8b69d3d7b5c9bf34fd0e
This is the second time we are alerted by the torchdata folks that something broke, but without our CI is picking up on it. Both times it was related to Windows and we didn't notice, because we only run the prototype tests on a Linux machine.
I'm wondering if we should switch to a Windows machine for prototype tests in CI given that AFAIK no one of us is developing on Windows. Thoughts @datumbox @NicolasHug ?
cc @pmeier @bjuncek