Skip to content

Fix DTD prototype dataset on Windows #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 31, 2022
Merged

Fix DTD prototype dataset on Windows #5227

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f0246cd
[DEBUG] run prototype tests on Windows
pmeier Jan 20, 2022
113eca4
disable duplicate resource class
pmeier Jan 20, 2022
f53cf60
fix newlines in mock data generation
pmeier Jan 20, 2022
e837220
fix path matching for DTD
pmeier Jan 20, 2022
6790971
revert CI changes
pmeier Jan 20, 2022
00b10c7
Revert "fix newlines in mock data generation"
pmeier Jan 20, 2022
edb9479
rerun tests with fix in torchdata
pmeier Jan 20, 2022
8e32a65
revert CI changes
pmeier Jan 20, 2022
63e473f
add explanation
pmeier Jan 31, 2022
3159f66
Merge branch 'main' into datasets/windows-ci
pmeier Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion torchvision/prototype/datasets/_builtin/dtd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ def _classify_archive(self, data: Tuple[str, Any]) -> Optional[int]:

def _image_key_fn(self, data: Tuple[str, Any]) -> str:
path = pathlib.Path(data[0])
return str(path.relative_to(path.parents[1]))
# The split files contain hardcoded posix paths for the images, e.g. banded/banded_0001.jpg
return str(path.relative_to(path.parents[1]).as_posix())

def _collate_and_decode_sample(
self,
Expand Down