Singular Sanitize BoundingBox #7316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Thanks a lot for the PR @mpearce25 , LGTM. Just 2 minor changes below were not needed, I'll edit them so we can merge the PR right now. Thanks!
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
Feb 24, 2023
Co-authored-by: Nicolas Hug <[email protected]>
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D44416560 fbshipit-source-id: db0ed0bfab6998a04650c2c2ec96dd31f2857649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7313
Standardize around singular "Box" as SanitizeBoundingBoxes was the only plural usage while the singular is used for all other classes.
Testing
pytest test/test_transforms_v2.py -vvvBoundingBoxesdoes not appear in codebase withrg -i "BoundingBoxes"