port lint workflows from CircleCI to GHA #7401
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/7401
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Can you make these jobs fail so we can get a sense of the workflow for checking the errors? |
|
I looked into why the C lint job emits quite few of these warnings: https://github.com/pytorch/vision/actions/runs/4375903581/jobs/7657253653#step:10:196
According to this SO answer, Since we are not building or testing here, this shouldn't be an issue and I tried that in 0ab8bf7. However the This was not an issue on CircleCI since we were able to install it as system package on Ubuntu: Lines 295 to 297 in e59cf64 The new runners use CentOS 7 and I was unable to install it through the system package manager. Thus, since this is only a warning and doesn't affect the job otherwise, I'm ok to keep it as is. Any concerns @NicolasHug? @osalpekar I don't think there is an option to specify a docker image for the generic Linux job, is there? |
|
still OK for me. We rely on the clang-format job once in a blue moon anyway |
There was a problem hiding this comment.
LGTM in general. As a longer term change, would be great to move linting to lintrunner like we have in PT Core (see more here: https://github.com/pytorch/pytorch/wiki/lintrunner). But this change is good-to-go!
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D44416612 fbshipit-source-id: 0c5e199258248c776dcec6606016abfeb50f78aa
Per title. I don't expect any problems here so I'm ok with removing the lint workflows on CircleCI right away. LMK if you disagree so I can revert d31f3bb.
cc @seemethere