Skip to content

fix lint c workflow #7409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix lint c workflow #7409

merged 1 commit into from
Mar 10, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 10, 2023

I messed up in #7401. ncurses=5, which is implicitly needed for the clang-format binary we are running, is not available on the conda defaults channel: https://github.com/pytorch/vision/actions/runs/4383741408/jobs/7674435301#step:10:110

Thus, we have to install from conda-forge here.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7409

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Collaborator Author

pmeier commented Mar 10, 2023

@pmeier pmeier requested a review from NicolasHug March 10, 2023 11:03
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@pmeier pmeier merged commit 7d2acaa into pytorch:main Mar 10, 2023
@pmeier pmeier deleted the lint-c branch March 10, 2023 11:07
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Reviewed By: vmoens

Differential Revision: D44416593

fbshipit-source-id: 359c42d84f22014400e657e23e4ba9b0d37e0028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants