Removing forcing of tqdm version for python2 #767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 40.31% 40.31%
=======================================
Files 29 29
Lines 2746 2746
Branches 432 432
=======================================
Hits 1107 1107
Misses 1563 1563
Partials 76 76Continue to review full report at Codecov.
|
|
#768 addresses this . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #766 which mentions problems with installing newer versions of the package due to tqdm==4.19.9.
This forcing was done in #542 due to error mentioned in #541.
The new release tqdm==4.31.1 handles the problem mentioned in #541 and no error appears on downloading.
I hope in the versions following 4.31.1 , tqdm wont regress to the same problem mentioned in #541 .
cc : @vishwakftw @fmassa