Skip to content

Remove dependency on tqdm #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Remove dependency on tqdm #768

merged 1 commit into from
Feb 28, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Feb 28, 2019

Fixes #766

@alsrgv
Copy link

alsrgv commented Feb 28, 2019

@fmassa, it looks like if tqdm is not installed, this actually does not work because tqdm fallback does not have no-argument constructor.

I found out because it broke our integration tests.

@soumith
Copy link
Member

soumith commented Mar 1, 2019

🤕 Francisco can you please land another fix and please test it this time. Going live on binaries with broken things like this is not a good thing.

@XavierAtShanghai
Copy link

I see the following error:

File ".../local/lib/python2.7/site-packages/torchvision/datasets/utils.py", line 73, in download_url
    reporthook=gen_bar_updater(tqdm())
TypeError: __init__() takes at least 2 arguments (1 given)

@fmassa
Copy link
Member Author

fmassa commented Mar 1, 2019

I'm fixing this, sorry about the breakage.
My testings were indeed not enough, I'm sorry about that

@fmassa
Copy link
Member Author

fmassa commented Mar 1, 2019

@alsrgv this should fix it #770

@alsrgv
Copy link

alsrgv commented Mar 1, 2019

@fmassa, it works now - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants