Skip to content

Fix for no tqdm #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Fix for no tqdm #770

merged 3 commits into from
Mar 1, 2019

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Mar 1, 2019

Fixes #769

The interface for PyTorch's tqdm doesn't support not passing the total argument, but it does support None.

Also adds tests, which should run in the "no-tqdm" configuration.

@fmassa fmassa mentioned this pull request Mar 1, 2019
@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #770 into master will increase coverage by 0.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   40.31%   40.99%   +0.67%     
==========================================
  Files          29       29              
  Lines        2746     2747       +1     
  Branches      432      432              
==========================================
+ Hits         1107     1126      +19     
+ Misses       1563     1542      -21     
- Partials       76       79       +3
Impacted Files Coverage Δ
torchvision/datasets/utils.py 48.38% <100%> (+30.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb6f88...68797b0. Read the comment docs.

@fmassa fmassa merged commit 6cc4970 into master Mar 1, 2019
@ailzhang
Copy link
Contributor

ailzhang commented Mar 1, 2019

Thanks @fmassa !

@fmassa fmassa deleted the fix-for-no-tqdm branch March 1, 2019 21:12
soumith pushed a commit that referenced this pull request Mar 1, 2019
* Fixes for PyTorch version of tqdm

* Flake

* Flake fix
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Mar 3, 2019
Summary:
Currently, the fake tqdm implementation requires an input (whereas real tqdm does not).

This caused a problem in torchvision (pytorch/vision#770), and seems likely to cause minor irritations elsewhere.
Pull Request resolved: #17636

Differential Revision: D14296530

Pulled By: ezyang

fbshipit-source-id: bc077d898773c93dab34c985a7b30525a43e558a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants