Fix for no tqdm #770
Merged
Fix for no tqdm #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 40.31% 40.99% +0.67%
==========================================
Files 29 29
Lines 2746 2747 +1
Branches 432 432
==========================================
+ Hits 1107 1126 +19
+ Misses 1563 1542 -21
- Partials 76 79 +3
Continue to review full report at Codecov.
|
|
Thanks @fmassa ! |
soumith
pushed a commit
that referenced
this pull request
Mar 1, 2019
* Fixes for PyTorch version of tqdm * Flake * Flake fix
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 3, 2019
Summary: Currently, the fake tqdm implementation requires an input (whereas real tqdm does not). This caused a problem in torchvision (pytorch/vision#770), and seems likely to cause minor irritations elsewhere. Pull Request resolved: #17636 Differential Revision: D14296530 Pulled By: ezyang fbshipit-source-id: bc077d898773c93dab34c985a7b30525a43e558a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #769
The interface for PyTorch's tqdm doesn't support not passing the
totalargument, but it does supportNone.Also adds tests, which should run in the "no-tqdm" configuration.