Add custom tags to Logon message. #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM JavaScript analysis failing. This is somewhat expected and triggered by changing the configuration html page. See #277 (comment) |
the-thing
approved these changes
May 13, 2020
There was a problem hiding this comment.
LGTM. Useful.
I know one or two venues requiring this. So far everybody has probably been intercepting Logon message in quickfix.Application#toAdmin and setting these fields manually (user + password).
I think somebody could "override" existing fields, but since this is optional functionality, they must ensure they know what they are doing anyway.
|
@the-thing , thanks for the review. |
|
BTW. I think you can close QFJ-177. |
jli8000
pushed a commit
to jli8000/quickfixj
that referenced
this pull request
Sep 22, 2020
Adds possibility to specify tags via setting `LogonTag` or `LogonTag<n>`. Example: ``` LogonTag=553=user LogonTag1=554=password ``` It is checked whether a data dictionary is present to determine whether the specified tag is a header field. Otherwise it is put into the body of the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to specify tags via setting
LogonTagorLogonTag<n>.Example:
It is checked whether a data dictionary is present to determine whether the specified tag is a header field. Otherwise it is put into the body of the message.