Support setting RefreshOnLogon for Initiators #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys `MsgType.LOGON` and check for acceptor could be removed anyway - extracted common code to method `refreshState()`
|
This is slightly confusing to review as the changes from other PR are here. #285 |
|
@the-thing , thanks, I have updated the PR. |
the-thing
suggested changes
May 14, 2020
jli8000
pushed a commit
to jli8000/quickfixj
that referenced
this pull request
Sep 22, 2020
* unify naming refreshAtLogon -> refreshOnLogon * unify naming refreshMessageStoreOnLogon -> refreshOnLogon * - removed method `isStateRefreshNeeded()`: passed `msgType` was always `MsgType.LOGON` and check for acceptor could be removed anyway - extracted common code to method `refreshState()` * Moved RefreshOnLogon to Misc section in documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262