Quote numbers in graticule labels #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decimal separator do not cause parsing to fail
|
Thanks Dewey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR quotes the numbers generated in
st_graticule(), so that these values can be safely passed toparse()in any locale (as reported in tidyverse/ggplot2#3365). This doesn't cause any changes in the ggplot2 doppleganger tests (tested using the re-enabled geom_sf() tests in tidyverse/ggplot2#3361), and thus I think it's unlikely that this will cause problems elsewhere (except in ggplot2's own tests, where we'll have to find a different way to test manual breaks in the graticule).