Skip to content

Update sf graticule label tests that will fail when the next sf version is released #3378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paleolimbot
Copy link
Member

After r-spatial/sf#1083 (which addressed #3365), several expectations in the coord_sf() test suite will fail with the next version of sf. This PR splits the affected test into several, small, well-labeled tests, and updates the expectations such that they will pass with the new version of sf (and the current version). This PR fixes #3365.

@paleolimbot paleolimbot requested a review from hadley July 1, 2019 20:02
@paleolimbot paleolimbot merged commit fe00b5c into tidyverse:master Jul 1, 2019
@paleolimbot paleolimbot deleted the issue-3365-sf-label-tests branch July 1, 2019 20:43
thomasp85 pushed a commit that referenced this pull request Aug 5, 2019
@thomasp85 thomasp85 mentioned this pull request Aug 5, 2019
thomasp85 added a commit that referenced this pull request Aug 9, 2019
@lock
Copy link

lock bot commented Dec 28, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_sf : error when using comma as decimal separator
2 participants