-
Notifications
You must be signed in to change notification settings - Fork 2k
Update libcamera README.md #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kamomil
commented
Dec 20, 2020
- Add note that it is impossible to use dtoverlay command to load the sensor overlay
- Add the needed pip3 installations
1. Add note that it is impossible to use dtoverlay command to load the sensor overlay 2. Add the needed pip3 installations
@@ -24,7 +24,7 @@ dtoverlay=imx219 | |||
core_freq_min=250 | |||
``` | |||
|
|||
If you are using a sensor other than the `imx219` you will need to supply the alternative name here (for example, `ov5647` for the V1 camera, or `imx477` for the HQ Cam for which support will be available shortly). | |||
If you are using a sensor other than the `imx219` you will need to supply the alternative name here (for example, `ov5647` for the V1 camera, or `imx477` for the HQ Cam for which support will be available shortly). It is impossible to load the sensor overlay dynamically with `dtoverlay` command as the firmware updates any override nodes that are named ["cam0-pwdn" or "cam0-pwdn-ctrl"](https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/imx219-overlay.dts#L111) (and cam1...) to point to the correct GPIO for that particular platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details of what is fixed up is not required.
It is not possible to load the sensor overlays dynamically with the dtoverlay
command as the firmware fixes up the overlays to point to the shutdown GPIO to the correct GPIO for the specific platform.
I'm just wondering if we're better off creating the regulator definitions in the base DT files with the correct GPIOs configured, and then all overlays can just reference those rather than needing to have things fixed up. Doing that would allow loading with dtoverlay
. The original fixup was written when the GPIO was configured as a shutdown/reset GPIO of the sensor driver, rather than the control GPIO of the regulator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this should be fixed for imx219 and imx477 by raspberrypi/linux#4051
ov5647 doesn't use the regulator framework, so that still needs the firmware fixups. A driver fix wouldn't go amiss there.
@@ -37,7 +37,7 @@ sudo apt install libboost-dev | |||
sudo apt install libgnutls28-dev openssl libtiff5-dev | |||
sudo apt install meson | |||
sudo apt install qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 | |||
sudo pip3 install pyyaml | |||
sudo pip3 install pyyaml ninja ply | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this is now required.
I'd encourage you to wrap this PR up in the next week or so as we're in the process of transitioning the documentation from the current Markdown-based source format to Asciidoc. At some point soon — probably around the end of June, beginning of July — we will freeze the current documentation repo. After that time contributions and PRs based on the Markdown source will not be accepted, and any PRs that are still open will be closed. See #1911 for full details. |
No one picked this up inside the 7 day closure window. So closing due to #1911. |