-
Notifications
You must be signed in to change notification settings - Fork 2k
Update libcamera README.md #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ dtoverlay=imx219 | |
core_freq_min=250 | ||
``` | ||
|
||
If you are using a sensor other than the `imx219` you will need to supply the alternative name here (for example, `ov5647` for the V1 camera, or `imx477` for the HQ Cam for which support will be available shortly). | ||
If you are using a sensor other than the `imx219` you will need to supply the alternative name here (for example, `ov5647` for the V1 camera, or `imx477` for the HQ Cam for which support will be available shortly). It is impossible to load the sensor overlay dynamically with `dtoverlay` command as the firmware updates any override nodes that are named ["cam0-pwdn" or "cam0-pwdn-ctrl"](https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/imx219-overlay.dts#L111) (and cam1...) to point to the correct GPIO for that particular platform. | ||
|
||
**NOTE**: after rebooting, control of the camera system will be passed to the ARM cores, and firmware-based camera functions (such as raspistill and so forth) will no longer work. Setting `/boot/config.txt` back and rebooting will restore the previous behaviour. | ||
|
||
|
@@ -37,7 +37,7 @@ sudo apt install libboost-dev | |
sudo apt install libgnutls28-dev openssl libtiff5-dev | ||
sudo apt install meson | ||
sudo apt install qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 | ||
sudo pip3 install pyyaml | ||
sudo pip3 install pyyaml ninja ply | ||
``` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can confirm this is now required. |
||
|
||
## Building _libcamera_ and _qcam_ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Details of what is fixed up is not required.
It is not possible to load the sensor overlays dynamically with the
dtoverlay
command as the firmware fixes up the overlays to point to the shutdown GPIO to the correct GPIO for the specific platform.I'm just wondering if we're better off creating the regulator definitions in the base DT files with the correct GPIOs configured, and then all overlays can just reference those rather than needing to have things fixed up. Doing that would allow loading with
dtoverlay
. The original fixup was written when the GPIO was configured as a shutdown/reset GPIO of the sensor driver, rather than the control GPIO of the regulator.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this should be fixed for imx219 and imx477 by raspberrypi/linux#4051
ov5647 doesn't use the regulator framework, so that still needs the firmware fixups. A driver fix wouldn't go amiss there.