Skip to content

Kodi 19 no sound over hdmi using fkms #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unformatted opened this issue Oct 17, 2021 · 24 comments
Open

Kodi 19 no sound over hdmi using fkms #4634

unformatted opened this issue Oct 17, 2021 · 24 comments

Comments

@unformatted
Copy link

Describe the bug
With the latest linux-raspberrypi kernel on RPi4 aarch64 and kodi-rpi I cannot select hdmi as audio output device anymore.

To reproduce
With config.txt as follows:
dtoverlay=vc4-fkms-v3d,cma-512
dtoverlay=rpivid-v4l2
dtoverlay=
dtparam=audio=on
From kodi, go to Settings > System > Audio > Audio output device.

Expected behaviour
hdmi selectable as an audio output device.

Actual behaviour
there's only headphone option.

System

  • RPi4
  • Arch ARM (aarch64)
  • linux-firmware 20210919.d526e04-1
  • linux-raspberrypi4 5.10.73-3

Additional context
Since kms heavily depends on the monitor's hdmi capabilties and I'm using an hdmi audio extractor in combination with a DVI monitor I have to use fkms. This worked fine until linux-raspberrypi4 5.10.63-18. After upgrading a few days ago hmdi sound was not available anymore. When I downgrade the current linux-raspberrypi4 5.10.73-2 kernel to linux-raspberrypi4 5.10.63-18 I have sound over hdmi back again. See also https://archlinuxarm.org/forum/viewtopic.php?f=65&t=15598 for more details.

@popcornmix
Copy link
Collaborator

Can you report output of dmesg, aplay -l and aplay -L for 5.10.63 and 5.10.73 kernels.

@Dark-Sky
Copy link

Dark-Sky commented Oct 17, 2021

With all of the latest 5.19, 5.14 and 5.15 kernels I have had to put this in cmdline.txt, not just kodi:

KMS:
snd-bcm2835.enable_compat_alsa=0
FKMS:
snd-bcm2835.enable_compat_alsa=1

Basically this looks like this it turns on and off the bcm2835-hdmi and vc4-hdmi sound. I am guessing the PiOS is using something different to accomplish this. This was done automatically before this depending on which mode you were booting along with the Headphones.

Our thread:

https://forum.manjaro.org/t/i-have-no-sound-output-through-hdmi-on-5-10-73-1-or-5-14-or-5-15/86485

@unformatted
Copy link
Author

@Dark-Sky: snd-bcm2835.enable_compat_alsa=1 works for me with fkms, thank you for the detailed information.

@popcornmix: do you still want me to report those outputs after Dark-Sky's answer?

@popcornmix
Copy link
Collaborator

If you are saying that then behaviour changed between 5.10.63 and 5.10.73 kernels, then I'd like to understand why (it's not something I'm immediately aware of having a new requirement). So the logs could b useful.

@Dark-Sky
Copy link

Dark-Sky commented Oct 17, 2021

In the past kernels fkms would boot ok. Starting with kernels 5.14 and 5.15 kernels I figured out I had to manually put values with snd-bcm2835.enable_compat_alsa= depending on which mode (kms/fkms). And with the last 5.10 this issue crept in. This is with no mention of snd-bcm2835.enable_compat_alsa=1 in cmdline.txt with fkms using V3D rendering. All you get is the headphones but what is strange is the hdmi seems to be picked up in inxi but not available to be picked if you open up the Sound Settings to switch Headphones is the only choice.

I have seen multiple times with in the last couple of months if these manual setting was not right on the 2 newer kernels that it would boot up to going into the graphical login or trying to enter kodi I would get a black screen and a message from my monitor saying "No Signal". I have not seen this on the latest 5.10 because as soon as I saw my sound situation I knew what to try to fix it.

pic

dmesg:
In the Kernel command line: snd_bcm2835.enable_compat_alsa=0 the value needs to be =1 for it to boot (in the past it was =0) with fkms with bcm2835-hdmi sound as it stands with now with the latest 5.10. 514 and 5.15 kernels.

https://drive.google.com/file/d/1LkM3gOQVSgLjuGjre07XYMpzy3UVESl2/view?usp=sharing

Xorg log:

https://drive.google.com/file/d/1ozSjN5ezFWZsL8PaZSvFfAVuuXivQO4G/view?usp=sharing

@Dark-Sky
Copy link

In contrast if I put snd-bcm2835.enable_compat_alsa=1 in cmdline.txt for fkms with v3d rendering and the hdmi sound works and seen in the Sound Settings.

enabled-aplay

enabled-inxi

@unformatted
Copy link
Author

@popcornmix :
Here's 5.10.63-18 dmesg: https://pastebin.com/2fjSnZLt
Here's 5.10.73-3 dmesg: https://pastebin.com/A6PTxEkH
I don't have aplay installed and for the moment while I'm still testing I won't install anything new.
If you want me to post other logs please let me know.

pelwell added a commit that referenced this issue Oct 18, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
@popcornmix
Copy link
Collaborator

I wonder if this problem is the same as #4635
@Dark-Sky can you test a kernel with the linked device tree commit?

pelwell added a commit that referenced this issue Oct 18, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
pelwell added a commit that referenced this issue Oct 18, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
@Dark-Sky
Copy link

I wonder if this problem is the same as #4635 @Dark-Sky can you test a kernel with the linked device tree commit?

Sure. Just getting up; need some coffee first.

@Dark-Sky
Copy link

@popcornmix I put the new bcm2711-rpi-4-b.dtb through a battery of tests and all is back to what it used to be. I removed any mention of snd-bcm2835.enable_compat_alsa= in config.txt and tested fkms/kms with V3D rendering with the DE and tested kodi-rpi 19.2 with kms and fkms.

As far as I am concerned this fixes and was a firestorm getting people to adjust to the way you all had it and we released new images with that change yesterday. Now I am having to re-live that memory all over again. Just wanted to let you know I understand. Game on again..... lol

cmdline.txt used in all tests:

root=PARTUUID=b75fdbb1-02 rw rootwait console=tty1 selinux=0 plymouth.enable=0 smsc95xx.turbo_mode=N dwc_otg.lpm_enable=0 usbhid.mousepoll=8 audit=0

fkms aplay -l:

card 0: b1 [bcm2835 HDMI 1], device 0: bcm2835 HDMI 1 [bcm2835 HDMI 1]
  Subdevices: 4/4
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
  Subdevice #2: subdevice #2
  Subdevice #3: subdevice #3
card 1: Headphones [bcm2835 Headphones], device 0: bcm2835 Headphones [bcm2835 Headphones]
  Subdevices: 4/4
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
  Subdevice #2: subdevice #2
  Subdevice #3: subdevice #3

kms aplay -l:

card 0: Headphones [bcm2835 Headphones], device 0: bcm2835 Headphones [bcm2835 Headphones]
  Subdevices: 8/8
  Subdevice #0: subdevice #0
  Subdevice #1: subdevice #1
  Subdevice #2: subdevice #2
  Subdevice #3: subdevice #3
  Subdevice #4: subdevice #4
  Subdevice #5: subdevice #5
  Subdevice #6: subdevice #6
  Subdevice #7: subdevice #7
card 1: vc4hdmi0 [vc4-hdmi-0], device 0: MAI PCM i2s-hifi-0 [MAI PCM i2s-hifi-0]
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 2: vc4hdmi1 [vc4-hdmi-1], device 0: MAI PCM i2s-hifi-0 [MAI PCM i2s-hifi-0]
  Subdevices: 1/1
  Subdevice #0: subdevice #0

A side note:

It has been mentioned that with kodi using fkms one does not get HW decoding. That is not the case here.

kodi-fkms

@pelwell
Copy link
Contributor

pelwell commented Oct 18, 2021

Now I am having to re-live that memory all over again.

Would sending you some stickers help?

@Dark-Sky
Copy link

Dark-Sky commented Oct 18, 2021

Would sending you some stickers help?

LOL. I am used to it I have been messing with the pi's since the first one came out. I even to this day get the first pi up to date just for nostalgia. All is good....

@popcornmix
Copy link
Collaborator

It has been mentioned that with kodi using fkms one does not get HW decoding. That is not the case here.

Correct. Hardware video decoding is not related to the choice of kms or fkms.

kms only affects the display pipeline (which includes hdmi audio), so there is probably some confusion with omxplayer and mmal variants of kodi which won't work with kms (for display reasons rather than decode reasons).

The newer v4l2 interfaces (for HEVC/H264, and MPEG4/MPEG-2/VC-1 on older Pi's) work fine with kms or fkms.

@Dark-Sky
Copy link

Dark-Sky commented Oct 18, 2021

I do not see specifically anything related to this change with the latest 5.14 and 5.15 kernels which has the same issue. I am reluctant to release new images if they still do not work with the same cmdline.txt now being used with this fix. A lot of the people are liking the current 5.15 kernel in the our forums. I guess I could copy over the new .dtb's in the kernel PKGBUILD but have not tested if all would be good.

@popcornmix
Copy link
Collaborator

I see the fix in 5.14/5.15. e.g. a415622

@Dark-Sky
Copy link

Thanks when I looked a while ago I did not see a change on that file in History.

@Dark-Sky
Copy link

I compiled and tested the latest 5.14 and 5.15 kernels and they appear to be good also.

popcornmix pushed a commit that referenced this issue Oct 19, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 19, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 22, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
@KonstaT
Copy link

KonstaT commented Oct 25, 2021

I'm experiencing a similar issue that wasn't fixed with 214bf6b.

When running with KMS and disabling VC4 HDMI devices (i.e. setting dtoverlay=vc4-kms-v3d,noaudio in /boot/config.txt) bcm2835-audio HDMI device is not present as it should be.

Running 5.10.74 kernel with latest firmware (https://github.com/raspberrypi/firmware/tree/d2ab264b688a223e23029ffbba86820c8c6cb329) I get:

[    3.899252] ALSA device list:
[    3.902277]   #0: bcm2835 Headphones

Same kernel but downgrade the firmware to https://github.com/raspberrypi/firmware/tree/d06e0ef85c22825a4491497a1d2a4787471f011b I get:

[   10.422612] ALSA device list:
[   10.425629]   #0: bcm2835 HDMI 1
[   10.428908]   #1: bcm2835 Headphones

This would be the expected behaviour. This doesn't work with any newer firmware (bisected this to something that changed between https://github.com/raspberrypi/firmware/tree/d06e0ef85c22825a4491497a1d2a4787471f011b and https://github.com/raspberrypi/firmware/tree/19272ccd69049aaf42c78a235a0bf37dbabd5ea7)

@pelwell @popcornmix
Any ideas? Should I open a separate issue for this (and where - kernel/firmware)?

@pelwell
Copy link
Contributor

pelwell commented Oct 25, 2021

Is this on a Pi 4? It may not matter, but it could make a difference. And thanks for bisecting it down to one commit - that's always helpful.

@KonstaT
Copy link

KonstaT commented Oct 25, 2021

Ah, yes. This is on Pi 4.

@pelwell
Copy link
Contributor

pelwell commented Oct 25, 2021

I'm investigating now, but in the meantime please do create a new issue.

popcornmix pushed a commit that referenced this issue Dec 7, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
@foice
Copy link

foice commented Dec 13, 2021

@Dark-Sky: snd-bcm2835.enable_compat_alsa=1 works for me with fkms, thank you for the detailed information.

@popcornmix: do you still want me to report those outputs after Dark-Sky's answer?

Confirm that

snd-bcm2835.enable_compat_alsa=1 works for me with fkms, and it is apparently ignore with kms

@Dark-Sky
Copy link

@Dark-Sky: snd-bcm2835.enable_compat_alsa=1 works for me with fkms, thank you for the detailed information.
@popcornmix: do you still want me to report those outputs after Dark-Sky's answer?

Confirm that

snd-bcm2835.enable_compat_alsa=1 works for me with fkms, and it is apparently ignore with kms

Which kernel are you using. You should not have to do it with the later kernels.

popcornmix pushed a commit that referenced this issue Dec 16, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Dec 17, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Dec 22, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
@foice
Copy link

foice commented Dec 26, 2021

#4634 (comment)

@Dark-Sky: snd-bcm2835.enable_compat_alsa=1 works for me with fkms, thank you for the detailed information.
@popcornmix: do you still want me to report those outputs after Dark-Sky's answer?

Confirm that
snd-bcm2835.enable_compat_alsa=1 works for me with fkms, and it is apparently ignore with kms

Which kernel are you using. You should not have to do it with the later kernels.

5.10.63-v7+ #1496 SMP Wed Dec 1 15:58:11 GMT 2021 armv7l GNU/Linux

popcornmix pushed a commit that referenced this issue Dec 31, 2021
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 5, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 11, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 17, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 24, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 25, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 28, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Jan 31, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Feb 7, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Feb 16, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Feb 18, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Feb 28, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 4, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 9, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
limeng-linux pushed a commit to limeng-linux/linux-yocto-5.15 that referenced this issue Mar 11, 2022
commit  526e02760deca2d46a90d7471804f1edf232e21a from
https://github.com/raspberrypi/linux.git rpi-5.15.y

The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: raspberrypi/linux#4634
     raspberrypi/linux#4635

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Meng Li <[email protected]>
limeng-linux pushed a commit to limeng-linux/linux-yocto-5.15 that referenced this issue Mar 11, 2022
commit  526e02760deca2d46a90d7471804f1edf232e21a from
https://github.com/raspberrypi/linux.git rpi-5.15.y

The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: raspberrypi/linux#4634
     raspberrypi/linux#4635

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Meng Li <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 15, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 21, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
popcornmix pushed a commit that referenced this issue Mar 21, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: #4634
     #4635

Signed-off-by: Phil Elwell <[email protected]>
Noltari pushed a commit to Noltari/rpi-linux that referenced this issue May 17, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: raspberrypi#4634
     raspberrypi#4635

Signed-off-by: Phil Elwell <[email protected]>
asheplyakov pushed a commit to asheplyakov/linux that referenced this issue May 24, 2022
The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: raspberrypi/linux#4634
     raspberrypi/linux#4635

Signed-off-by: Phil Elwell <[email protected]>
papamoose pushed a commit to papamoose/ubuntu-kernel-raspi-jammy that referenced this issue Sep 3, 2022
BugLink: https://bugs.launchpad.net/bugs/1958146

The firmware driver has been changed to count its clients. An earlier
commit removed the downstream patch permitting the hacky technique of
passing NULL to rpi_firmware_get to pick up the last instace, but
failed to add the necessary "firmware" property to the bcm2835_audio
node. Correct that omission.

See: raspberrypi/linux#4634
     raspberrypi/linux#4635

Signed-off-by: Phil Elwell <[email protected]>

(cherry picked from commit f46dcb9ec472aa0860213141cba7f0e57a267fe0 rpi-5.15.y)
Signed-off-by: Juerg Haefliger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants