HDMI audio inop in rpi-5.10.y (et al)... plus patch that resolved it for me #4635

yetanotheraccount · 2021-10-17T18:33:11Z

firmware-Fix-merge-artifact-that-lost-one-hunk-of-e4a6adeb157e.txt

popcornmix · 2021-10-17T18:37:31Z

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

pelwell · 2021-10-18T10:20:18Z

The patch targets the problem, but it's a step back to the old way of doing things when we should be embracing the new. 214bf6b is the proper fix, and is now in rpi-5.10.y (with cherry-picks to rpi-5.14.y and rpi-5.15.y underway).

See: raspberrypi/linux#4634 See: raspberrypi/linux#4635

popcornmix · 2021-10-18T10:44:44Z

rpi-update kernel now includes this fix.

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

yetanotheraccount · 2021-10-18T11:10:34Z

Saw those commits when I pulled a few minutes ago and thought they looked suspiciously like a proper fix. Thanks.

yetanotheraccount · 2021-10-18T11:28:42Z

Well bugger, I just booted v5.15-rc5-564-g5f932e9e05e5 sans lost hunk patchlet, and have no HDMI audio. Push lost hunk patchlet and rebuild, and it's back. So proper fix ain't quite complete it seems.

pelwell · 2021-10-18T11:38:42Z

It works for me. Are you sure you bumped the .dtbs as well? It would be easy to forget.

yetanotheraccount · 2021-10-18T12:20:32Z

Hm, given I have not the foggiest clue what "bump the .dtbs" means, that's probably why it didn't work for me :) What I've been doing is sudo make modules_install dtbs_install install.

pelwell · 2021-10-18T12:34:56Z

"make dtbs_install" should do the job, but you can confirm whether an updated dtb is running with:

pi@raspberrypi:~ $ od --endian=big -tu4 /proc/device-tree/soc/firmware/phandle
pi@raspberrypi:~ $ od --endian=big -tu4 /proc/device-tree/soc/mailbox@7e00b840/bcm2835_audio/brcm\,firmware

both of which should return the same answer (the phandle of the firmware node, which in my case was 6 but the precise value is unimportant).

yetanotheraccount · 2021-10-18T13:04:50Z

Hm. I repeated the whack patchlet, rebuild and reinstall dance yet again. and... presto, HDMI audio is now there, and the two od incantations do say the same (0000000 and 0000004). That's kinda weird, but I'll take :) We're done I suppose, thanks again.

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

commit 4332c30c7cbb2e4ff90af83d2d5e6d2950617ba2 from https://github.com/raspberrypi/linux.git rpi-5.15.y The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: raspberrypi/linux#4634 raspberrypi/linux#4635 Signed-off-by: Phil Elwell <[email protected]> Signed-off-by: Meng Li <[email protected]>

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

pelwell · 2022-01-06T09:02:23Z

It looks OK to me - the fixing patch added on 18 Oct is still present.

Where and how do you get your dtbs?
What is the git hash or release tag for your current release?
Which platform are you testing on?
What is the md5sum for the base .dtb, e.g.: md5sum /boot/bcm2711-rpi-4-b.dtb?

yetanotheraccount · 2022-01-06T09:20:55Z

Where and how do you get your dtbs?
make modules_install dtbs_install install
What is the git hash or release tag for your current release?
Current release?
hash of 5.16.y branch is currently at v5.16-rc8-619-gb2818e05874d
(or b2818e0)
Which platform are you testing on?
rpi4b
What is the md5sum for the base .dtb, e.g.: md5sum /boot/bcm2711-rpi-4-b.dtb?
pi@rpi4:~ $ md5sum /boot/bcm2711-rpi-4-b.dtb
2f29c47b7a9cf7979bca2f9a2d4aa5a1 /boot/bcm2711-rpi-4-b.dtb

yetanotheraccount · 2022-01-06T10:00:37Z

Ok, seems /boot/bcm2711-rpi-4-b.dtb is the problem. make modules_install dtbs_install install does not install arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb. Making a backup copy of /boot/bcm2711-rpi-4-b.dtb then replacing it with the one from the built source fixes the problem. However, that also broke the distribution kernel, but...

Hohum, this is looking rather a lot like an "x86 guy has a sh*tload to learn about cute little arm64 gizmos" thing to me :)

pelwell · 2022-01-06T10:24:30Z

You may find it has installed /boot/broadcom/bcm2711-rpi-4-b.dtb instead.

The 64-bit DTBs are the same as the 32-bit ones, to the extent that you may find it easier to build and install them from a 32-bit configuration - there will just be the bcm2* dtbs, not those for the entire range of 64-bit ARM devices.

pelwell · 2022-01-06T10:37:57Z

FYI the correct md5sums for a Pi 4 dtb in 32-bit and 64-bit builds of b2818e0 (and current rpi-5.16.y head d09973c) are:

1c9b38da0a3bece74abb36894b68cd29  arch/arm/boot/dts/bcm2711-rpi-4-b.dtb
1c9b38da0a3bece74abb36894b68cd29  arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb

yetanotheraccount · 2022-01-06T10:54:35Z

FYI the correct md5sums for a Pi 4 dtb in 32-bit and 64-bit builds of b2818e0 (and current rpi-5.16.y head d09973c) are:
1c9b38da0a3bece74abb36894b68cd29  arch/arm/boot/dts/bcm2711-rpi-4-b.dtb
1c9b38da0a3bece74abb36894b68cd29  arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dtb

That hash is the one I manually installed, and both 5.10.y and 5.16.y HEAD work fine with it. It's too bad the distributed kernel (5.10.63) does NOT, but no big deal, looks like that should eventually self-correct.

pelwell · 2022-01-06T11:18:24Z

/proc/device-tree/soc/mailbox@7e00b840/bcm2835_audio/brcm,firmware I was directed to above seems to no longer exist btw, not even in the working delivered 5.10.63-v8+ kernel.

Our 5.10.63 build dates from 8 Sep - over a month before the patch went in - and unfortunately our time machine is down for scheduled maintenance.

yetanotheraccount · 2022-01-06T11:22:49Z

Our 5.10.63 build dates from 8 Sep - over a month before the patch went in - and unfortunately our time machine is down for scheduled maintenance.

:)

Ok, so looks like I can close this thing.. again.. any maybe even keep it that way.

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

commit 526e02760deca2d46a90d7471804f1edf232e21a from https://github.com/raspberrypi/linux.git rpi-5.15.y The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: raspberrypi/linux#4634 raspberrypi/linux#4635 Signed-off-by: Phil Elwell <[email protected]> Signed-off-by: Meng Li <[email protected]>

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: #4634 #4635 Signed-off-by: Phil Elwell <[email protected]>

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: raspberrypi#4634 raspberrypi#4635 Signed-off-by: Phil Elwell <[email protected]>

The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: raspberrypi/linux#4634 raspberrypi/linux#4635 Signed-off-by: Phil Elwell <[email protected]>

BugLink: https://bugs.launchpad.net/bugs/1958146 The firmware driver has been changed to count its clients. An earlier commit removed the downstream patch permitting the hacky technique of passing NULL to rpi_firmware_get to pick up the last instace, but failed to add the necessary "firmware" property to the bcm2835_audio node. Correct that omission. See: raspberrypi/linux#4634 raspberrypi/linux#4635 Signed-off-by: Phil Elwell <[email protected]> (cherry picked from commit f46dcb9ec472aa0860213141cba7f0e57a267fe0 rpi-5.15.y) Signed-off-by: Juerg Haefliger <[email protected]>

popcornmix mentioned this issue Oct 18, 2021

Kodi 19 no sound over hdmi using fkms #4634

Open

popcornmix added a commit to raspberrypi/firmware that referenced this issue Oct 18, 2021

kernel: ARM: dts: bcm2835_audio missing firmware reference

bd43c40

See: raspberrypi/linux#4634 See: raspberrypi/linux#4635

popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Oct 18, 2021

kernel: ARM: dts: bcm2835_audio missing firmware reference

1597995

See: raspberrypi/linux#4634 See: raspberrypi/linux#4635

yetanotheraccount closed this as completed Oct 18, 2021

yetanotheraccount closed this as completed Jan 6, 2022

HDMI audio inop in rpi-5.10.y (et al)... plus patch that resolved it for me #4635

HDMI audio inop in rpi-5.10.y (et al)... plus patch that resolved it for me #4635

Comments

yetanotheraccount commented Oct 17, 2021

popcornmix commented Oct 17, 2021

Uh oh!

pelwell commented Oct 18, 2021

Uh oh!

popcornmix commented Oct 18, 2021

Uh oh!

yetanotheraccount commented Oct 18, 2021

Uh oh!

yetanotheraccount commented Oct 18, 2021

Uh oh!

pelwell commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yetanotheraccount commented Oct 18, 2021

Uh oh!

pelwell commented Oct 18, 2021

Uh oh!

yetanotheraccount commented Oct 18, 2021

Uh oh!

pelwell commented Jan 6, 2022

Uh oh!

yetanotheraccount commented Jan 6, 2022

Uh oh!

yetanotheraccount commented Jan 6, 2022

Uh oh!

pelwell commented Jan 6, 2022

Uh oh!

pelwell commented Jan 6, 2022

Uh oh!

yetanotheraccount commented Jan 6, 2022

Uh oh!

pelwell commented Jan 6, 2022

Uh oh!

yetanotheraccount commented Jan 6, 2022

Uh oh!

pelwell commented Oct 18, 2021 •

edited

Loading