Skip to content

dts: Added overlay for gpio_ir_recv driver #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hsteinhaus
Copy link

This PR adds a DTS that allows the use of the gpio_ir_recv kernel driver.

The gpio_ir_recv driver is a rc-core based driver for TSOP-style IR receivers connected to a GPIO pin and is part of the Linux kernel. In contrast to lirc_rpi, no LIRC is needed for IR signal decoding or RC key mapping. These tasks are done by proven kernel infrastructure instead.

In contrast to the LIRC/lirc_rpi approach, the gpio_ir_recv driver brings a better RC responsiveness and a more consistent timing between RC button pressed and and key event and does not suffer from the typical double-key problems often reported from the lirc_rpi/LIRCd approach.

@popcornmix
Copy link
Collaborator

Looks reasonable to me. @pelwell ?

@pelwell
Copy link
Contributor

pelwell commented Nov 14, 2015

It looks OK to me (I'm away and can't test it though).

Just FYI the strings "off", "down" and "up" translate to the values 0, 1 and 2 when assigning to an integer dtparam.

@hsteinhaus
Copy link
Author

Just FYI the strings "off", "down" and "up" translate to the values 0, 1 and 2 when assigning to an integer dtparam.

Wow, this devicetree stuff is really magic ;)

I will change the comments and doc accordingly in a follow-up commit shortly.

@popcornmix
Copy link
Collaborator

Can you squash the commits together and force push? (git rebase -i HEAD~2 and git push -f).

@pelwell
Copy link
Contributor

pelwell commented Nov 17, 2015

Thanks for squashing - we don't receive notifications for a push, hence the slow response.

My automated checker spotted that a parameter name was incorrect in the README, and while I was correcting that I spotted the absence of "dtoverlay=" in the Load: section, so I've patched it up and pushed the new commit. I've also improved the checker and corrected some similar issues elsewhere in the README - I can see where you copied it from.

Thanks for the contribution.

@pelwell pelwell closed this Nov 17, 2015
@hsteinhaus hsteinhaus deleted the gpio_ir_overlay branch November 17, 2015 10:43
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Dec 8, 2015
kernel: BCM270X_DT: Use clk_core for I2C interfaces
See: #212

kernel: SDIO-overlay: add poll_once-boolean parameter

kernel: dts: Added overlay for gpio_ir_recv driver
See: raspberrypi/linux#1199

kernel: Add FBUNSUPPORTED ioctl for bcm2708_fb
See: raspberrypi/linux#1200

kernel: config: Add FB_TFT_ILI9163 module
See: raspberrypi/linux#1177
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this pull request Dec 8, 2015
kernel: BCM270X_DT: Use clk_core for I2C interfaces
See: raspberrypi/firmware#212

kernel: SDIO-overlay: add poll_once-boolean parameter

kernel: dts: Added overlay for gpio_ir_recv driver
See: raspberrypi/linux#1199

kernel: Add FBUNSUPPORTED ioctl for bcm2708_fb
See: raspberrypi/linux#1200

kernel: config: Add FB_TFT_ILI9163 module
See: raspberrypi/linux#1177
neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this pull request Feb 27, 2017
kernel: BCM270X_DT: Use clk_core for I2C interfaces
See: raspberrypi#212

kernel: SDIO-overlay: add poll_once-boolean parameter

kernel: dts: Added overlay for gpio_ir_recv driver
See: raspberrypi/linux#1199

kernel: Add FBUNSUPPORTED ioctl for bcm2708_fb
See: raspberrypi/linux#1200

kernel: config: Add FB_TFT_ILI9163 module
See: raspberrypi/linux#1177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants